[jifty-devel] Upload field broken in trunk

[Stanislav Sinyagin]

actually I fixed the problem now.

Inside take_action(), I used to have

my $filehandle = $self->argument_value('upload_file');
my $parser   = new Spreadsheet::ParseExcel;
my $workbook = $parser->Parse($filehandle);

It appears that now $filehandle contains a Jifty::Web::FileUpload object, and 
it fails to return its filehandle through the overloaded methods.

After replacing the last line to 
my $workbook = $parser->Parse($filehandle->filehandle());
it works again.

I don't know what kind of object was returned by argument_value in the old past.










----- Original Message ----
> From: Shawn M Moore <sartak at bestpractical.com>
> To: jifty-devel at lists.jifty.org
> Sent: Thu, April 1, 2010 8:42:31 PM
> Subject: Re: [jifty-devel] Upload field broken in trunk
> 
> Hi Stanislav,
> 
> (2/11/10 9:51 AM), Stanislav Sinyagin wrote:
> >  hi,
> > 
> > it works in   Jifty-0.91117 from CPAN, and in the  current trunk it's 
broken:
> 
> I've added a failing test that tries to  trigger this same bug. It's
> t/TestApp-Uploads/t/back-compat.t added by  76a1f6b6.
> 
> Does this new test fail for you? If not, could you tweak it so  that it
> better matches the actual action you use?
> 
> If you could git  bisect Jifty to see which revision broke it for you,
> that would be useful in  debugging.
> 
> > I'm running lighthttpd+fcgi on a Linux box.
> 
> I  wonder if it's an inconsistency in  Plack..
> 
> Shawn
> _______________________________________________
> jifty-devel  mailing list
> jifty-devel at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
>