[jifty-devel] Die on Missing Template?

Jesse Vincent jesse at bestpractical.com
Fri Oct 30 00:35:36 EDT 2009




On Thu, Oct 29, 2009 at 09:09:55PM -0700, David E. Wheeler wrote:
> Howdy,
> 
> Any reason not to apply this patch (plus test updates)? I can't  
> imagine a situation in which I'd want things to continue when I tried  
> to execute a template that wasn't there.

(David and I talked about this on IRC. Short version is "I'm thrilled to
see this become configurable, but please don't break my default
semantics, which I use today")
> 
> --- a/lib/Template/Declare/Tags.pm
> +++ b/lib/Template/Declare/Tags.pm
> @@ -866,8 +866,7 @@ sub _show_template {
>      unless ($callable) {
>          my $msg = "The template '$template' could not be found";
>          $msg .= " (it might be private)" if !$inside_template;
> -        carp $msg;
> -        return '';
> +        croak $msg;
>      }
> 
>      if (my $instrumentation = Template::Declare->around_template) {
> 
> Best,
> 
> David
> _______________________________________________
> jifty-devel mailing list
> jifty-devel at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
> 

-- 


More information about the jifty-devel mailing list