[jifty-devel] Die on Missing Template?

David E. Wheeler david at kineticode.com
Fri Oct 30 00:09:55 EDT 2009


Howdy,

Any reason not to apply this patch (plus test updates)? I can't  
imagine a situation in which I'd want things to continue when I tried  
to execute a template that wasn't there.

--- a/lib/Template/Declare/Tags.pm
+++ b/lib/Template/Declare/Tags.pm
@@ -866,8 +866,7 @@ sub _show_template {
     unless ($callable) {
         my $msg = "The template '$template' could not be found";
         $msg .= " (it might be private)" if !$inside_template;
-        carp $msg;
-        return '';
+        croak $msg;
     }

     if (my $instrumentation = Template::Declare->around_template) {

Best,

David


More information about the jifty-devel mailing list