[jifty-devel] Re: [Jifty-commit] r4782 - in jifty/trunk: lib/Jifty/Web

[Jesse Vincent]

I bet we want a helper method called is_static_content or something so
we can encapsulate that expires() hack ;)

or to have it be a boolean in the response that the static server can set.

-j

jifty-commit at lists.jifty.org wrote:
> Author: sartak
> Date: Thu Jan  3 17:15:21 2008
> New Revision: 4782
> 
> Modified:
>    jifty/trunk/   (props changed)
>    jifty/trunk/lib/Jifty/Web/Session.pm
> 
> Log:
>  r49872 at onn:  sartak | 2008-01-03 17:14:31 -0500
>  Never send a cookie with cached content. Misbehaving proxies cause terrific problems.
> 
> 
> Modified: jifty/trunk/lib/Jifty/Web/Session.pm
> ==============================================================================
> --- jifty/trunk/lib/Jifty/Web/Session.pm	(original)
> +++ jifty/trunk/lib/Jifty/Web/Session.pm	Thu Jan  3 17:15:21 2008
> @@ -317,6 +317,10 @@
>  sub set_cookie {
>      my $self = shift;
>  
> +    # never send a cookie with cached content. misbehaving proxies cause
> +    # terrific problems
> +    return if Jifty->handler->apache->header_out('Expires');
> +
>      my $cookie_name = $self->cookie_name;
>      my %cookies     = CGI::Cookie->fetch();
>      my $cookie = new CGI::Cookie(
> _______________________________________________
> Jifty-commit mailing list
> Jifty-commit at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-commit
>