[jifty-devel] Re: [Jifty-commit] r4545 - jifty/trunk/lib/Jifty/Plugin/OpenID

[Andrew Sterling Hanenkamp]

gugod,

It's my understanding that if you:

  $action = Jifty->web->new_action( class => 'AuthenticateOpenID' );

and a plugin provides an AuthenticateOpenID action, what happens is that
class loader builds an application class named:

  App::Action::AuthenticateOpenID

that subclasses:

  Jifty::Plugin::OpenID::Action::AuthenticateOpenID

This was intentional and I've been meaning to go back in and alter the way
plugins provide models to mirror this. Is there a problem with this
behavior?

Cheers,
Andrew

On Nov 27, 2007 12:33 AM, <jifty-commit at lists.jifty.org> wrote:

> Author: gugod
> Date: Tue Nov 27 01:33:54 2007
> New Revision: 4545
>
> Modified:
>   jifty/trunk/lib/Jifty/Plugin/OpenID/Dispatcher.pm
>
> Log:
> Unbreak OpenID plugin with new Jifty::API implementation.
>
> Give fully-qualified action class name here because Jifty::API does
> not resolve action class names to those ones provided by plugins
> (those under Jifty::Plugin::*::Action namespace) This is maybe a
> bug, but need further discussion.
>
>
> Modified: jifty/trunk/lib/Jifty/Plugin/OpenID/Dispatcher.pm
>
> ==============================================================================
> --- jifty/trunk/lib/Jifty/Plugin/OpenID/Dispatcher.pm   (original)
> +++ jifty/trunk/lib/Jifty/Plugin/OpenID/Dispatcher.pm   Tue Nov 27
> 01:33:54 2007
> @@ -20,7 +20,7 @@
>
>  before qr'^/openid/login' => run {
>     set action => Jifty->web->new_action(
> -        class   => 'AuthenticateOpenID',
> +        class   => 'Jifty::Plugin::OpenID::Action::AuthenticateOpenID',
>         moniker => 'authenticateopenid'
>     );
>  };
> @@ -97,7 +97,7 @@
>         redirect '/';
>     }
>
> -    set action => Jifty->web->new_action( class => 'CreateOpenIDUser',
> parameters => { openid => Jifty->web->session->get("openid") } );
> +    set action => Jifty->web->new_action( class =>
> 'Jifty::Plugin::OpenID::Action::CreateOpenIDUser', parameters => { openid =>
> Jifty->web->session->get("openid") } );
>     set 'next' => Jifty->web->request->continuation ||
>                   Jifty::Continuation->new( request =>
> Jifty::Request->new( path => "/" ) );
>  };
> _______________________________________________
> Jifty-commit mailing list
> Jifty-commit at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-commit
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.bestpractical.com/pipermail/jifty-devel/attachments/20071127/f81b8314/attachment.htm