[jifty-devel] RE: [Jifty-commit] r3038 - in jifty/trunk: lib/Jifty/Test/WWW

[Jesse Vincent]

Sok. Looks like the only tests it broke were in our non-public app.

-j
On Mar 21, 2007, at 8:32 AM, Andrew Sterling Hanenkamp wrote:

> My apologies. I will change the documentation at the top of the  
> file, then, that indicates that click_button is being used.
>
> --
> Andrew Sterling Hanenkamp
> Interaction Developer
> Boomer Consulting, Inc.
>
> 1.785.537.2358 ext. 17
> 1.888.266.6375 ext. 17
> 1.785.537.4545 (fax)
>
> 610 Humboldt
> Manhattan, KS 66502
>
> http://www.boomer.com/about/team/andrew-hanenkamp.html
> andrew.hanenkamp at boomer.com
> -----Original Message-----
> From: jifty-commit-bounces at lists.jifty.org [mailto:jifty-commit- 
> bounces at lists.jifty.org] On Behalf Of jifty-commit at lists.jifty.org
> Sent: Tuesday, March 20, 2007 8:05 PM
> To: jifty-commit at lists.jifty.org
> Subject: [Jifty-commit] r3038 - in jifty/trunk: lib/Jifty/Test/WWW
>
> Author: jesse
> Date: Tue Mar 20 21:05:02 2007
> New Revision: 3038
>
> Modified:
>    jifty/trunk/   (props changed)
>    jifty/trunk/lib/Jifty/Test/WWW/Mechanize.pm
>
> Log:
>  r53747 at pinglin:  jesse | 2007-03-20 21:04:44 -0400
>  * When you break an API, it breaks tests.
>
>
>
> Modified: jifty/trunk/lib/Jifty/Test/WWW/Mechanize.pm
> ====================================================================== 
> ========
> --- jifty/trunk/lib/Jifty/Test/WWW/Mechanize.pm	(original)
> +++ jifty/trunk/lib/Jifty/Test/WWW/Mechanize.pm	Tue Mar 20 21:05:02  
> 2007
> @@ -387,29 +387,14 @@
>
>  =head2 submit_html_ok
>
> -With no arguments, this method calls L<WWW::Mechanize/submit>.
> -
> -  $mech->submit_html_ok();
> -
> -With arguments, it calls L<WWW::Mechanize/click_button> and passes  
> all arguments to it.
> -
> -  $mech->submit_html_ok( value => 'Save' );
> -
> -In both cases, this call is followed by testing the HTML using
> +Calls C<submit>, followed by testing the HTML using
>  L<Test::HTML::Lint>.
>
>  =cut
>
>  sub submit_html_ok {
>      my $self = shift;
> -
> -    if (@_) {
> -        $self->click_button(@_);
> -    }
> -    else {
> -        $self->submit;
> -    }
> -
> +    $self->submit(@_);
>      {
>          local $Test::Builder::Level = $Test::Builder::Level;
>          $Test::Builder::Level++;
> _______________________________________________
> Jifty-commit mailing list
> Jifty-commit at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-commit
> _______________________________________________
> jifty-devel mailing list
> jifty-devel at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 186 bytes
Desc: This is a digitally signed message part
Url : http://lists.bestpractical.com/pipermail/jifty-devel/attachments/20070321/3e935a02/PGP.pgp