[jifty-devel] Patch for allowing an array of values within limit

Edward Funnekotter efunneko at gmail.com
Tue Aug 21 22:05:10 EDT 2007


Sorry about missing that (no Postgres on my end).  Is there anything you
would like me to do?


On 8/21/07, Kevin Falcone <falcone at bestpractical.com> wrote:
>
>
> On Aug 21, 2007, at 1:49 PM, Kevin Falcone wrote:
>
> >
> > On Aug 20, 2007, at 5:01 PM, Edward Funnekotter wrote:
> >
> >> Thanks Jesse.  I have committed it to the Jifty-DBI trunk
> >> (r3923).  You can now easily limit yourself to a known set of values.
> >
> > Unfortunately, the case insensitive IN test fails on Postgres
>
> Fix coming to a commit-mailing-list near you soon
>
> -kevin
>
> >
> > #   Failed test 'case insensitive, non-matched case, should find
> > two rows'
> > #   at t/01searches.t line 189.
> > #          got: '0'
> > #     expected: '2'
> > not ok 272 - case insensitive, non-matched case, should find two rows
> >
> > -kevin
> >
> >>
> >>
> >> On 8/20/07, Jesse Vincent <jesse at bestpractical.com> wrote: looks
> >> good. go for it.
> >> On Aug 15, 2007, at 10:01 AM, Edward Funnekotter wrote:
> >>
> >> > Hi all,
> >> >
> >> > Here is a patch for your perusal that contains fixes to Jifty-DBI
> >> > to allow a limit clause to contain an array ref.  This gets
> >> > converted to an 'IN' operator within the built SQL query.  The
> >> > operator can be either 'IN' or '='.
> >> >
> >> > E.g.
> >> >
> >> >         $users_obj->limit( column => 'login',
> >> >                            operator => 'IN',
> >> >                            value => ['cubic', 'obra', 'glasser',
> >> > 'audreyt'] );
> >> >
> >> > Could someone in the know, take a peek and ok the commit?
> >> >
> >> > Thanks,
> >> > Edward
> >> >
> >> >
> >> > <in_operator_patch.gz>
> >> > _______________________________________________
> >> > jifty-devel mailing list
> >> > jifty-devel at lists.jifty.org
> >> > http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
> >>
> >>
> >> _______________________________________________
> >> jifty-devel mailing list
> >> jifty-devel at lists.jifty.org
> >> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
> >>
> >>
> >>
> >> _______________________________________________
> >> jifty-devel mailing list
> >> jifty-devel at lists.jifty.org
> >> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
> >
> > _______________________________________________
> > jifty-devel mailing list
> > jifty-devel at lists.jifty.org
> > http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
> >
>
> _______________________________________________
> jifty-devel mailing list
> jifty-devel at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.bestpractical.com/pipermail/jifty-devel/attachments/20070821/da4f96fe/attachment-0001.htm


More information about the jifty-devel mailing list