[jifty-devel] Patches via irc
marc at questright.com
Thu Apr 19 01:29:04 EDT 2007
I'm new to Jifty, working on a project where the client requested Jifty
as the framework. So I'm trying to get up to speed as quickly as I can.
I'm semifor on irc and nopasted a couple of patches there.
Your preference for using the e-mail list works fine for me. I hadn't
yet joined the list and had the patches not gotten a response I would
have joined and posted them.
I've worked in other projects where the common practice is to post
trivial patches to the irc channel for a quick once over by any devs
that happen to be online. Sometimes they say "take it to the list",
sometimes they patch them directly, and often they offer guidance on how
to improve the patch.
I was just testing the water. I'm happy to work with the local
The patches I provided were for issues I discovered while trying to get
the trunk version working with the Doxory example.
The patch you didn't apply is trivial and perhaps not even worth
mentioning. You indicated it was a noop. It may not be important, but
it isn't exactly a noop. The current code will never produce the value
255. It will produce values 0 through 254 inclusive. My patch produces
values 0 through 255 inclusive. If the intent was to include 255 in the
values produced, then my patch is a fix. If not, it's immaterial.
I've included the patch here, again, for your review. No offense taken
if it isn't applied. Like I said, it is trivial even if it is a "fix".
--- lib/Jifty/Plugin/Authentication/Password/Mixin/Model/User.pm (revision 3154)
+++ lib/Jifty/Plugin/Authentication/Password/Mixin/Model/User.pm (working copy)
@@ -128,7 +128,7 @@
my $self = shift;
my $auth_token = '';
- $auth_token .= unpack('H2', chr(int rand(255))) for (1..16);
+ $auth_token .= unpack('H2', chr(int rand(256))) for (1..16);
$self->__set(column => 'auth_token', value => $auth_token);
More information about the jifty-devel