[jifty-devel] Re: [Jifty-commit] r2362 - jifty/trunk/lib/Jifty

[Jesse Vincent]

Gugod, This change is going to cause changes to rendering of existing
applications, no? If so, could you back it out so we can discuss it?

-jesse
On Sun, Dec 10, 2006 at 07:57:35AM -0500, jifty-commit at lists.jifty.org wrote:
> Author: gugod
> Date: Sun Dec 10 07:57:33 2006
> New Revision: 2362
> 
> Modified:
>    jifty/trunk/lib/Jifty/Action.pm
> 
> Log:
> This helps passing xhtml validation.
> <input> cannot be direclty under <form>, there should be a
> block-level element in-between.
> 
> Modified: jifty/trunk/lib/Jifty/Action.pm
> ==============================================================================
> --- jifty/trunk/lib/Jifty/Action.pm	(original)
> +++ jifty/trunk/lib/Jifty/Action.pm	Sun Dec 10 07:57:33 2006
> @@ -438,7 +438,7 @@
>                if exists $field_info->{'default_value'};
>              $default_value = $self->argument_value($field)
>                if $self->has_argument($field) && !$self->values_from_request->{$field};
> -            
> +
>              $self->{_private_form_fields_hash}{$arg_name}
>                  = Jifty::Web::Form::Field->new(
>                  %$field_info,
> @@ -451,7 +451,6 @@
>                  %args
>                  );
>  
> -            
>          }    # else $field remains undef
>          else {
>              Jifty->log->warn("$arg_name isn't a valid field for $self");
> @@ -502,11 +501,11 @@
>  
>  sub register {
>      my $self = shift;
> -    Jifty->web->out( qq!<input type="hidden"! .
> +    Jifty->web->out( qq!<div><input type="hidden"! .
>                         qq! name="@{[$self->register_name]}"! .
>                         qq! id="@{[$self->register_name]}"! .
>                         qq! value="@{[ref($self)]}"! .
> -                       qq! />\n! );
> +                       qq! /></div>\n! );
>  
>  
>  
> _______________________________________________
> Jifty-commit mailing list
> Jifty-commit at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-commit
> 

--