[Jifty-commit] jifty branch, master, updated. 1.10518-45-g58eb17a

Jifty commits jifty-commit at lists.jifty.org
Fri Sep 23 14:47:03 EDT 2011


The branch, master has been updated
       via  58eb17a40ab9d628554cb06e6089a4c7d1257c0f (commit)
       via  17e8d65a31b7d107d524ba7c2787d1e4121c5909 (commit)
      from  732d91ef004e1a9bd94f1cffb8c8349eae25d749 (commit)

Summary of changes:
 lib/Jifty/Handler.pm          |    4 +++-
 t/TestApp/lib/TestApp/View.pm |    2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

- Log -----------------------------------------------------------------
commit 17e8d65a31b7d107d524ba7c2787d1e4121c5909
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Sep 23 14:29:33 2011 -0400

    Test that printing with multiple arguments works
    
    Even if it's deprecated, we should still print everything.  This adds a
    failing test.

diff --git a/t/TestApp/lib/TestApp/View.pm b/t/TestApp/lib/TestApp/View.pm
index 664dd0c..3f1b789 100644
--- a/t/TestApp/lib/TestApp/View.pm
+++ b/t/TestApp/lib/TestApp/View.pm
@@ -156,7 +156,7 @@ template 'otherplace' => page {
 };
 
 template 'naughty' => sub {
-    print STDOUT "this is bad";
+    print STDOUT "this is ", "bad";
 };
 
 1;

commit 58eb17a40ab9d628554cb06e6089a4c7d1257c0f
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Sep 23 14:36:44 2011 -0400

    Print more than just the first argument in our overridden version of print
    
    Respecting $, and $\ (as described in `perldoc -f print`) probably isn't
    necessary, but it's more correct.

diff --git a/lib/Jifty/Handler.pm b/lib/Jifty/Handler.pm
index b7a4a5b..95488bd 100644
--- a/lib/Jifty/Handler.pm
+++ b/lib/Jifty/Handler.pm
@@ -230,7 +230,9 @@ sub handle_request {
             carp "printing to STDOUT is deprecated.  Use outs, outs_raw or Jifty->web->response->body() instead";
 
             my $self = shift;
-            Jifty->handler->buffer->out_method->(shift);
+            my $comma = defined $, ? $, : '';
+            my $slash = defined $\ ? $\ : '';
+            Jifty->handler->buffer->out_method->( join($comma, @_) . $slash );
         };
 
     local *STDOUT = io_to_glob($trapio);

-----------------------------------------------------------------------


More information about the Jifty-commit mailing list