[Jifty-commit] jifty branch, master, updated. 1.10518-16-gc8c4fd2

Jifty commits jifty-commit at lists.jifty.org
Wed Jun 1 13:18:02 EDT 2011


The branch, master has been updated
       via  c8c4fd27238e2f66a64e04e066c621b8ec37e045 (commit)
      from  81830b96e6315f5b1998caa0de8e6c04fc2977c2 (commit)

Summary of changes:
 lib/Jifty/Web/Form/Field.pm |   17 -----------------
 1 files changed, 0 insertions(+), 17 deletions(-)

- Log -----------------------------------------------------------------
commit c8c4fd27238e2f66a64e04e066c621b8ec37e045
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Wed Jun 1 13:13:51 2011 -0400

    Remove the unused focus_javascript method
    
    This should have been removed by 8fa0c5c80 which added return undef
    instead to short circuit the javascript.

diff --git a/lib/Jifty/Web/Form/Field.pm b/lib/Jifty/Web/Form/Field.pm
index af6b3ba..76ae6ca 100644
--- a/lib/Jifty/Web/Form/Field.pm
+++ b/lib/Jifty/Web/Form/Field.pm
@@ -425,7 +425,6 @@ sub render_inline_javascript {
             $self->autocomplete_javascript(),
             $self->placeholder_javascript(),
             $self->key_binding_javascript(),
-            $self->focus_javascript(),
             $self->preload_javascript(),
         )
     );
@@ -690,22 +689,6 @@ sub placeholder_javascript {
     return qq!new Jifty.Placeholder('@{[$self->element_id]}', '$placeholder');!;
 }
 
-=head2 focus_javascript
-
-Returns the javascript necessary to focus this form field on page
-load, if necessary.
-
-=cut
-
-sub focus_javascript {
-    my $self = shift;
-    return undef;
-    if($self->focus) {
-        return qq!document.getElementById("@{[$self->element_id]}").focus();!;
-        return qq!jQuery(document).ready(function(){jQuery("#@{[$self->element_id]}").focus()});!;
-    }
-}
-
 =head2 preload_javascript
 
 Returns the javascript necessary to load regions that have been marked for

-----------------------------------------------------------------------


More information about the Jifty-commit mailing list