[Jifty-commit] jifty-dbi branch, master, updated. 0.64-6-g0e93d34

[Jifty commits]

The branch, master has been updated
       via  0e93d3427d77c71392a2e8f131b26a30cd2e474d (commit)
      from  9e37991c91c1dd50f6bca515ea4556e56e52699e (commit)

Summary of changes:
 lib/Jifty/DBI/Collection.pm |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

- Log -----------------------------------------------------------------
commit 0e93d3427d77c71392a2e8f131b26a30cd2e474d
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Tue Jan 25 12:27:07 2011 -0500

    Explain a comment regarding joins and column objects

diff --git a/lib/Jifty/DBI/Collection.pm b/lib/Jifty/DBI/Collection.pm
index ea50a43..519699c 100755
--- a/lib/Jifty/DBI/Collection.pm
+++ b/lib/Jifty/DBI/Collection.pm
@@ -1255,7 +1255,9 @@ sub limit {
         : $args{'column'};
     my $clause_id = $args{'subclause'} || $qualified_column;
 
-    # XXX: when is column_obj undefined?
+    # $column_obj is undefined when the table2 argument to the join is a table
+    # name and not a collection model class.  In that case, the class key
+    # doesn't exist for the join.
     my $class
         = $self->{joins}{ $args{alias} }
         && $self->{joins}{ $args{alias} }{class}

-----------------------------------------------------------------------