[Jifty-commit] jifty branch, autocomplete-refactor, updated. 98fd15c1ad4ae5fe6279710874280ebbf14303f3
Jifty commits
jifty-commit at lists.jifty.org
Tue Mar 23 12:06:23 EDT 2010
The branch, autocomplete-refactor has been updated
via 98fd15c1ad4ae5fe6279710874280ebbf14303f3 (commit)
from 05b0acee5fa0932924b1265dc9231d7ab3521f59 (commit)
Summary of changes:
lib/Jifty/Web/Form/Field.pm | 2 +-
share/web/static/js/jifty.js | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
- Log -----------------------------------------------------------------
commit 98fd15c1ad4ae5fe6279710874280ebbf14303f3
Author: Shawn M Moore <sartak at bestpractical.com>
Date: Tue Mar 23 12:06:14 2010 -0400
Use # only in the jQuery selector, not in the Jifty.$
diff --git a/lib/Jifty/Web/Form/Field.pm b/lib/Jifty/Web/Form/Field.pm
index 78e7298..b8462ef 100644
--- a/lib/Jifty/Web/Form/Field.pm
+++ b/lib/Jifty/Web/Form/Field.pm
@@ -669,7 +669,7 @@ sub autocomplete_javascript {
my $self = shift;
return unless($self->autocompleter);
my $element_id = $self->element_id;
- return "jQuery(document).ready(function(){Jifty.addAutocompleter('#$element_id');});"
+ return "jQuery(document).ready(function(){Jifty.addAutocompleter('$element_id');});"
}
=head2 placeholder_javascript
diff --git a/share/web/static/js/jifty.js b/share/web/static/js/jifty.js
index 89e3077..1ac15ba 100644
--- a/share/web/static/js/jifty.js
+++ b/share/web/static/js/jifty.js
@@ -1723,12 +1723,12 @@ function show_action_result() {
}
Jifty.addAutocompleter = function (id) {
- var escaped_id = id.replace(/:/g, '\\\\\\:');
-
var field = Jifty.$(id);
var action = Jifty.Form.Element.getAction(field);
- jQuery(escaped_id).autocomplete('/__jifty/autocomplete.xss', {
+ var selector = '#' + id.replace(/:/g, '\\\\\\:');
+
+ jQuery(selector).autocomplete('/__jifty/autocomplete.xss', {
cache: false,
extraParams: function () {
var request = { path: this.url, actions: {} };
-----------------------------------------------------------------------
More information about the Jifty-commit
mailing list