[Jifty-commit] jifty branch, master, updated. e6cb698f9b7e2b83198a3466989c3f7cc7972a3b

[Jifty commits]

The branch, master has been updated
       via  e6cb698f9b7e2b83198a3466989c3f7cc7972a3b (commit)
      from  48c1327800493f95cd5a8acca642fb646822d870 (commit)

Summary of changes:
 lib/Jifty/Web/Form/Element.pm |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

- Log -----------------------------------------------------------------
commit e6cb698f9b7e2b83198a3466989c3f7cc7972a3b
Author: Thomas Sibley <trs at bestpractical.com>
Date:   Fri Jan 8 17:34:50 2010 -0500

    Warn if a keybinding won't work due to a missing ID

diff --git a/lib/Jifty/Web/Form/Element.pm b/lib/Jifty/Web/Form/Element.pm
index 5fed9be..a9a313d 100644
--- a/lib/Jifty/Web/Form/Element.pm
+++ b/lib/Jifty/Web/Form/Element.pm
@@ -638,6 +638,10 @@ sub key_binding_javascript {
                     ? $self->key_binding_label
                     : $self->label;
     if ($key) {
+        $self->log->warn("Keybinding '@{[uc $key]}' will NOT work because the"
+                        ." element ('$label') does not have an ID.")
+            if not defined $self->id or not length $self->id;
+
         return "Jifty.KeyBindings.add("
                 . Jifty::JSON::encode_json( uc $key ).","
                 . "'click', "

-----------------------------------------------------------------------