[Jifty-commit] r7628 - jifty/trunk/lib/Jifty/Action/Record

Jifty commits jifty-commit at lists.jifty.org
Tue Nov 17 21:14:31 EST 2009


Author: sartak
Date: Tue Nov 17 21:14:28 2009
New Revision: 7628

Modified:
   jifty/trunk/lib/Jifty/Action/Record/Create.pm
   jifty/trunk/lib/Jifty/Action/Record/Update.pm

Log:
No longer need to explicitly handle file uploads in actions

Modified: jifty/trunk/lib/Jifty/Action/Record/Create.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Action/Record/Create.pm	(original)
+++ jifty/trunk/lib/Jifty/Action/Record/Create.pm	Tue Nov 17 21:14:28 2009
@@ -80,14 +80,6 @@
 
         # Prepare the hash to pass to create for each argument
         $values{$_} = $self->argument_value($_);
-
-        # Handle file uploads
-        if (ref $values{$_} eq "Fh") { # CGI.pm's "lightweight filehandle class"
-            local $/;
-            my $fh = $values{$_};
-            binmode $fh;
-            $values{$_} = scalar <$fh>;
-        }
     }
 
     # Attempt creating the record

Modified: jifty/trunk/lib/Jifty/Action/Record/Update.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Action/Record/Update.pm	(original)
+++ jifty/trunk/lib/Jifty/Action/Record/Update.pm	Tue Nov 17 21:14:28 2009
@@ -127,13 +127,6 @@
           and lc $self->arguments->{$field}{render_as} eq "upload"
           and (not defined $value or not ref $value);
 
-        # Handle file uploads
-        if (ref $value eq "Fh") { # CGI.pm's "lightweight filehandle class"
-            local $/;
-            binmode $value;
-            $value = scalar <$value>;
-        }
-
         # Skip fields that have not changed, but only if we can read the field.
         # This prevents us from getting an $old value that is wrongly undef
         # when really we are just denied read access.  At the same time, it means


More information about the Jifty-commit mailing list