[Jifty-commit] r7072 - jifty/trunk/lib/Jifty

Jifty commits jifty-commit at lists.jifty.org
Tue May 19 14:32:01 EDT 2009


Author: sartak
Date: Tue May 19 14:32:01 2009
New Revision: 7072

Modified:
   jifty/trunk/lib/Jifty/Action.pm

Log:
Factor out field args into a hash for inspection :)

Modified: jifty/trunk/lib/Jifty/Action.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Action.pm	(original)
+++ jifty/trunk/lib/Jifty/Action.pm	Tue May 19 14:32:01 2009
@@ -506,9 +506,7 @@
         $default_value = $self->argument_value($field)
           if $self->has_argument($field) && !$self->values_from_request->{$field};
 
-        # Add the form field to the cache
-        $self->{_private_form_fields_hash}{$arg_name}
-            = Jifty::Web::Form::Field->new(
+        my %field_args = (
             %$field_info,
             action        => $self,
             name          => $field,
@@ -516,10 +514,12 @@
             sticky_value  => $self->argument_value($field),
             default_value => $default_value,
             render_mode   => $args{'render_mode'},
-            %args
-            );
-
+            %args,
+        );
 
+        # Add the form field to the cache
+        $self->{_private_form_fields_hash}{$arg_name}
+            = Jifty::Web::Form::Field->new(%field_args);
     } 
     # It has been cached, but render_as is explicitly set
     elsif ( my $widget = $args{render_as} ) {


More information about the Jifty-commit mailing list