[Jifty-commit] r7236 - jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action

Jifty commits jifty-commit at lists.jifty.org
Thu Jun 11 15:34:47 EDT 2009


Author: sartak
Date: Thu Jun 11 15:34:46 2009
New Revision: 7236

Modified:
   jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm

Log:
connect returning undef is an error condition we need to report

Modified: jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm	Thu Jun 11 15:34:46 2009
@@ -42,12 +42,13 @@
     my $handle = Jifty::DBI::Handle->new;
     my $ok = eval {
         local $SIG{__DIE__};
-        $handle->connect(%{ $self->argument_values })
+        $handle->connect(%args);
     };
     my $error = $@;
-    warn $error if $error;
 
     if (!$ok) {
+        $error ||= _("No handle created");
+        warn $error;
         return $self->result->error($error);
     }
 


More information about the Jifty-commit mailing list