[Jifty-commit] r5177 - in Jifty-DBI/trunk: lib/Jifty/DBI/Filter

Jifty commits jifty-commit at lists.jifty.org
Thu Feb 28 23:10:49 EST 2008


Author: sartak
Date: Thu Feb 28 23:10:47 2008
New Revision: 5177

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Filter/Boolean.pm

Log:
 r52257 at onn:  sartak | 2008-02-28 23:10:41 -0500
 Complain if the encoded/decoded value doesn't return one of _is_true or _is_false.


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Filter/Boolean.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Filter/Boolean.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Filter/Boolean.pm	Thu Feb 28 23:10:47 2008
@@ -52,7 +52,16 @@
 
     return unless defined $$value_ref;
 
-    $$value_ref = $self->_is_true($$value_ref);
+    if ($self->_is_true($$value_ref)) {
+        $$value_ref = 1;
+    }
+    elsif ($self->_is_false($$value_ref)) {
+        $$value_ref = 0;
+    }
+    else {
+        $self->handle->log("The value '$$value_ref' does not look like a boolean. Defaulting to false.");
+        $$value_ref = 0;
+    }
 }
 
 =head2 decode
@@ -73,14 +82,18 @@
     if ($self->_is_true($$value_ref)) {
         $$value_ref = $self->handle->canonical_true;
     }
+    elsif ($self->_is_false($$value_ref)) {
+        $$value_ref = $self->handle->canonical_false;
+    }
     else {
+        $self->handle->log("The value '$$value_ref' does not look like a boolean. Defaulting to false.");
         $$value_ref = $self->handle->canonical_false;
     }
 }
 
 =head1 SEE ALSO
 
-L<Jifty::DBI::Filter>, L<Time::Duration>, L<Time::Duration::Parse>
+L<Jifty::DBI::Filter>
 
 =cut
 


More information about the Jifty-commit mailing list