[Jifty-commit] r5175 - in Jifty-DBI/trunk: . lib/Jifty/DBI

[Jifty commits]

Author: sartak
Date: Thu Feb 28 22:46:13 2008
New Revision: 5175

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Filter.pm
   Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
   Jifty-DBI/trunk/t/06filter.t

Log:
 r52247 at onn:  sartak | 2008-02-28 22:45:56 -0500
 Have filters receive the database handle


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Filter.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Filter.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Filter.pm	Thu Feb 28 22:46:13 2008
@@ -4,7 +4,7 @@
 package Jifty::DBI::Filter;
 use base 'Class::Accessor::Fast';
 
-__PACKAGE__->mk_accessors(qw(record column value_ref));
+__PACKAGE__->mk_accessors(qw(record column value_ref handle));
 
 =head1 NAME
 
@@ -52,7 +52,7 @@
 
 =head2 new
 
-Takes two arguments in a parameter hash:
+Takes three arguments in a parameter hash:
 
 =over
 
@@ -69,6 +69,13 @@
 
 =back
 
+=item handle
+
+A L<Jifty::DBI::Handle> object, because some filters (ie
+L<Jifty::DBI::Filter::Boolean>) depend on what database system is being used.
+
+=back
+
 =cut
 
 sub new {
@@ -76,6 +83,7 @@
     my %args  = (
         column    => undef,
         value_ref => undef,
+        handle    => undef,
         @_
     );
     my $self = {};

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	Thu Feb 28 22:46:13 2008
@@ -1569,6 +1569,7 @@
             record    => $self,
             column    => $args{'column'},
             value_ref => $args{'value_ref'},
+            handle    => $self->_handle,
         );
 
         # XXX TODO error proof this

Modified: Jifty-DBI/trunk/t/06filter.t
==============================================================================
--- Jifty-DBI/trunk/t/06filter.t	(original)
+++ Jifty-DBI/trunk/t/06filter.t	Thu Feb 28 22:46:13 2008
@@ -4,7 +4,7 @@
 
 use Test::More;
 BEGIN { require "t/utils.pl" }
-plan tests => 6;
+plan tests => 7;
 # test for Jifty::DBI::Filter class only
 # create new t/06filter_*.t files for specific filters
 
@@ -14,6 +14,7 @@
 isa_ok( $filter, 'Jifty::DBI::Filter' );
 is( $filter->column, undef, "empty column value" );
 is( $filter->value_ref, undef, "empty value reference" );
+is( $filter->handle, undef, "empty handle" );
 
 $filter->column( 'my column' );
 is( $filter->column, 'my column', "successfuly set column" );