[Jifty-commit] r4992 - Jifty-DBI/trunk/lib/Jifty/DBI

Jifty commits jifty-commit at lists.jifty.org
Mon Feb 4 19:12:19 EST 2008


Author: ruz
Date: Mon Feb  4 19:12:16 2008
New Revision: 4992

Modified:
   Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm

Log:
* micro-optimization of _filters which is called quite often

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	Mon Feb  4 19:12:16 2008
@@ -1528,14 +1528,13 @@
     my $self = shift;
     my %args = ( direction => 'input', column => undef, @_ );
 
-    my @filters = ();
-    my @objs = ( $self, $args{'column'}, $self->_handle );
-    @objs = reverse @objs if $args{'direction'} eq 'output';
-    my $method = $args{'direction'} . "_filters";
-    foreach my $obj (@objs) {
-        push @filters, $obj->$method();
+    if ( $args{'direction'} eq 'input' ) {
+        return grep $_, map $_->input_filters,
+            ( $self, $args{'column'}, $self->_handle );
+    } else {
+        return grep $_, map $_->output_filters,
+            ( $self->_handle, $args{'column'}, $self );
     }
-    return grep $_, @filters;
 }
 
 sub _apply_input_filters {


More information about the Jifty-commit mailing list