[Jifty-commit] r4261 - in jifty/trunk: . lib/Jifty/Plugin/OAuth

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Fri Oct 19 11:50:34 EDT 2007


Author: sartak
Date: Fri Oct 19 11:50:33 2007
New Revision: 4261

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/Makefile.PL
   jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm
   jifty/trunk/t/TestApp-Plugin-OAuth/t/00-test-setup.t
   jifty/trunk/t/TestApp-Plugin-OAuth/t/01-basic.t
   jifty/trunk/t/TestApp-Plugin-OAuth/t/02-request-token.t

Log:
 r43871 at onn:  sartak | 2007-10-19 11:50:24 -0400
 Require Net::OAuth 0.04 because 0.03 needs my patch
 Don't run tests if Net::OAuth is uninstalled


Modified: jifty/trunk/Makefile.PL
==============================================================================
--- jifty/trunk/Makefile.PL	(original)
+++ jifty/trunk/Makefile.PL	Fri Oct 19 11:50:33 2007
@@ -167,7 +167,7 @@
     ],
     'OAuth Plugin' => [
         -default => 0,
-        recommends('Net::OAuth::Request'),
+        recommends('Net::OAuth::Request' => '0.04'),
         recommends('Crypt::OpenSSL::RSA'),
         recommends('Digest::HMAC_SHA1'),
         recommends('MIME::Base64'),

Modified: jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/OAuth/Dispatcher.pm	Fri Oct 19 11:50:33 2007
@@ -65,7 +65,6 @@
         oauth_token_secret => $token->secret
     };
     show 'oauth/response';
-    abortmsg(200, 'Correctly issued a Request Token');
 }
 
 # the user is authorizing (or denying) a consumer's request token
@@ -140,7 +139,6 @@
         oauth_token_secret => $token->secret
     };
     show 'oauth/response';
-    abortmsg(200, 'Correctly issued an Access Token');
 }
 
 sub get_consumer {

Modified: jifty/trunk/t/TestApp-Plugin-OAuth/t/00-test-setup.t
==============================================================================
--- jifty/trunk/t/TestApp-Plugin-OAuth/t/00-test-setup.t	(original)
+++ jifty/trunk/t/TestApp-Plugin-OAuth/t/00-test-setup.t	Fri Oct 19 11:50:33 2007
@@ -5,7 +5,14 @@
 use lib 't/lib';
 use Jifty::SubTest;
 
-use TestApp::Plugin::OAuth::Test tests => 9;
+use TestApp::Plugin::OAuth::Test;
+
+if (eval { require Net::OAuth::Request; 1 }) {
+    plan tests => 9;
+}
+else {
+    plan skip_all => "Net::OAuth isn't installed";
+}
 
 # sign PLAINTEXT {{{
 is(sign('POST', 'jjd999tj88uiths3', 'djr9rjt0jd78jf88',

Modified: jifty/trunk/t/TestApp-Plugin-OAuth/t/01-basic.t
==============================================================================
--- jifty/trunk/t/TestApp-Plugin-OAuth/t/01-basic.t	(original)
+++ jifty/trunk/t/TestApp-Plugin-OAuth/t/01-basic.t	Fri Oct 19 11:50:33 2007
@@ -5,7 +5,15 @@
 use lib 't/lib';
 use Jifty::SubTest;
 
-use Jifty::Test tests => 9;
+use Jifty::Test;
+
+if (eval { require Net::OAuth::Request; 1 }) {
+    plan tests => 9;
+}
+else {
+    plan skip_all => "Net::OAuth isn't installed";
+}
+
 use Jifty::Test::WWW::Mechanize;
 
 my $server  = Jifty::Test->make_server;

Modified: jifty/trunk/t/TestApp-Plugin-OAuth/t/02-request-token.t
==============================================================================
--- jifty/trunk/t/TestApp-Plugin-OAuth/t/02-request-token.t	(original)
+++ jifty/trunk/t/TestApp-Plugin-OAuth/t/02-request-token.t	Fri Oct 19 11:50:33 2007
@@ -5,7 +5,15 @@
 use lib 't/lib';
 use Jifty::SubTest;
 
-use TestApp::Plugin::OAuth::Test tests => 50;
+use TestApp::Plugin::OAuth::Test;
+
+if (eval { require Net::OAuth::Request; 1 }) {
+    plan tests => 50;
+}
+else {
+    plan skip_all => "Net::OAuth isn't installed";
+}
+
 use Jifty::Test::WWW::Mechanize;
 
 my $server  = Jifty::Test->make_server;


More information about the Jifty-commit mailing list