[Jifty-commit] r4388 - in Jifty-DBI/trunk: t

[jifty-commit at lists.jifty.org]

Author: jesse
Date: Wed Nov  7 12:25:44 2007
New Revision: 4388

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/Changes
   Jifty-DBI/trunk/META.yml
   Jifty-DBI/trunk/t/02records_cachable.t
   Jifty-DBI/trunk/t/02searches_joins.t
   Jifty-DBI/trunk/t/04memcached.t
   Jifty-DBI/trunk/t/17virtualtypes.t
   Jifty-DBI/trunk/t/18triggers.t
   Jifty-DBI/trunk/t/utils.pl

Log:
 r71477 at pinglin:  jesse | 2007-11-07 12:24:25 -0500
  * stray tempfile leakage fixed. reported by andk


Modified: Jifty-DBI/trunk/Changes
==============================================================================
--- Jifty-DBI/trunk/Changes	(original)
+++ Jifty-DBI/trunk/Changes	Wed Nov  7 12:25:44 2007
@@ -1,5 +1,9 @@
 Revision history for Perl extension Jifty::DBI.
 
+0.46 Wed Nov  7 12:24:08 EST 2007
+
+ - POD Coverage nit
+ - Fix for a stray tempfiles bug reported by ANDK
 
 0.45
 

Modified: Jifty-DBI/trunk/META.yml
==============================================================================
--- Jifty-DBI/trunk/META.yml	(original)
+++ Jifty-DBI/trunk/META.yml	Wed Nov  7 12:25:44 2007
@@ -37,4 +37,4 @@
   YAML::Syck: 0
   perl: 5.8.3
   version: 0
-version: 0.43
+version: 0.45

Modified: Jifty-DBI/trunk/t/02records_cachable.t
==============================================================================
--- Jifty-DBI/trunk/t/02records_cachable.t	(original)
+++ Jifty-DBI/trunk/t/02records_cachable.t	Wed Nov  7 12:25:44 2007
@@ -117,6 +117,7 @@
         Jifty::DBI::Record::Cachable->flush_cache;
 
         cleanup_schema( 'TestApp::Address', $handle );
+        disconnect_handle($handle);
     }
 }    # SKIP, foreach blocks
 

Modified: Jifty-DBI/trunk/t/02searches_joins.t
==============================================================================
--- Jifty-DBI/trunk/t/02searches_joins.t	(original)
+++ Jifty-DBI/trunk/t/02searches_joins.t	Wed Nov  7 12:25:44 2007
@@ -213,7 +213,7 @@
 }
 
     cleanup_schema( 'TestApp', $handle );
-
+    disconnect_handle($handle);
 }} # SKIP, foreach blocks
 
 1;

Modified: Jifty-DBI/trunk/t/04memcached.t
==============================================================================
--- Jifty-DBI/trunk/t/04memcached.t	(original)
+++ Jifty-DBI/trunk/t/04memcached.t	Wed Nov  7 12:25:44 2007
@@ -65,6 +65,7 @@
         $rec = TestApp::Address->new( handle => $handle );
         $rec->load($id);
         is($rec->phone, '555 543 6789', "Loaded changed data from cache OK");
+        disconnect_handle($handle);
 }}
 
 package TestApp::Address;

Modified: Jifty-DBI/trunk/t/17virtualtypes.t
==============================================================================
--- Jifty-DBI/trunk/t/17virtualtypes.t	(original)
+++ Jifty-DBI/trunk/t/17virtualtypes.t	Wed Nov  7 12:25:44 2007
@@ -38,6 +38,7 @@
         is($rec->location_x, 10);
         is($rec->location_y, 20);
         is_deeply($rec->location, { x => 10, y => 20});
+        disconnect_handle($handle);
     }
 }
 

Modified: Jifty-DBI/trunk/t/18triggers.t
==============================================================================
--- Jifty-DBI/trunk/t/18triggers.t	(original)
+++ Jifty-DBI/trunk/t/18triggers.t	Wed Nov  7 12:25:44 2007
@@ -44,6 +44,7 @@
 
     my $ret = $rec->delete;
     ok($ret, 'deleted a record');
+    disconnect_handle($handle);
 };
 }
 

Modified: Jifty-DBI/trunk/t/utils.pl
==============================================================================
--- Jifty-DBI/trunk/t/utils.pl	(original)
+++ Jifty-DBI/trunk/t/utils.pl	Wed Nov  7 12:25:44 2007
@@ -1,7 +1,7 @@
 #!/usr/bin/env perl -w
 
 use strict;
-use File::Spec ();
+use File::Temp ();
 
 =head1 VARIABLES
 
@@ -22,6 +22,9 @@
         Sybase
 );
 
+
+
+
 =head2 @available_drivers
 
 Array that lists only drivers from supported list
@@ -93,13 +96,15 @@
         goto &$call;
 }
 
+
+our $SQLITE_FILENAME;
 sub connect_sqlite
 {
         my $handle = shift;
+        (undef, $SQLITE_FILENAME ) = File::Temp::tempfile();
         return $handle->connect(
                 driver => 'SQLite',
-                database => File::Spec->catfile(File::Spec->tmpdir(), "sb-test.$$")
-        );
+                database => $SQLITE_FILENAME);
 }
 
 sub connect_mysql
@@ -166,7 +171,7 @@
 {
         my $handle = shift;
         $handle->disconnect;
-        unlink File::Spec->catfile(File::Spec->tmpdir(), "sb-test.$$");
+        unlink $SQLITE_FILENAME;
 }
 
 sub disconnect_mysql