[Jifty-commit] r3072 - in Jifty-DBI/trunk: lib/Jifty/DBI

[jifty-commit at lists.jifty.org]

Author: jesse
Date: Thu Mar 29 18:00:40 2007
New Revision: 3072

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
   Jifty-DBI/trunk/lib/Jifty/DBI/Column.pm

Log:
 r54311 at pinglin:  jesse | 2007-03-29 14:59:32 -0700
 * Better non-lower()ing of non-string types on search.


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	Thu Mar 29 18:00:40 2007
@@ -1022,7 +1022,7 @@
 
         # don't worry about case for numeric columns_in_db
         my $column_obj = $self->new_item()->column( $args{column} );
-        if ( defined $column_obj ? !$column_obj->is_numeric : 1 ) {
+        if ( defined $column_obj ? $column_obj->is_string : 1 ) {
             ( $qualified_column, $args{'operator'}, $args{'value'} )
                 = $self->_handle->_make_clause_case_insensitive(
                 $qualified_column, $args{'operator'}, $args{'value'} );

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Column.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Column.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Column.pm	Thu Mar 29 18:00:40 2007
@@ -62,6 +62,26 @@
     return 0;
 }
 
+
+
+=head2 is_string
+
+Returns true if this column is a text field
+
+=cut
+
+
+sub is_string {
+    my $self = shift;
+    if ( $self->type =~ /CHAR/i ){ 
+        return 1;
+    }
+    return 0;
+}
+
+
+
+
 =head2 validator
 
 Gets/sets the validator coderef for the column.