[Jifty-commit] r3487 - Jifty-DBI/trunk/lib/Jifty/DBI

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Thu Jun 14 16:54:08 EDT 2007


Author: ruz
Date: Thu Jun 14 16:54:06 2007
New Revision: 3487

Modified:
   Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm

Log:
* join defined and not empty subclauses only

Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm	Thu Jun 14 16:54:06 2007
@@ -1141,10 +1141,7 @@
     #Go through all restriction types. Build the where clause from the
     #Various subclauses.
 
-    my @subclauses;
-    foreach my $subclause ( sort keys %{ $self->{'subclauses'} } ) {
-        push @subclauses, $self->{'subclauses'}{"$subclause"};
-    }
+    my @subclauses = grep defined && length, values %{ $self->{'subclauses'} };
 
     $where_clause = " WHERE " . CORE::join( ' AND ', @subclauses )
         if (@subclauses);


More information about the Jifty-commit mailing list