[Jifty-commit] r3748 - in jifty/trunk: t/TestApp-Plugin-Chart/t

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Tue Jul 31 22:32:48 EDT 2007


Author: sterling
Date: Tue Jul 31 22:32:48 2007
New Revision: 3748

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/t/TestApp-Plugin-Chart/t/chart.t

Log:
 r8268 at dynpc145:  andrew | 2007-07-31 21:28:14 -0500
 Added a hack to chart.t (forcing an early load of GD) to avoid the segfault that was causing it to fail. Removed the TODO block from the test.


Modified: jifty/trunk/t/TestApp-Plugin-Chart/t/chart.t
==============================================================================
--- jifty/trunk/t/TestApp-Plugin-Chart/t/chart.t	(original)
+++ jifty/trunk/t/TestApp-Plugin-Chart/t/chart.t	Tue Jul 31 22:32:48 2007
@@ -4,6 +4,10 @@
 
 use lib 't/lib';
 
+# XXX FIXME This is here to prevent a segfault on my machine during testing.
+#   -- sterling
+use GD;
+
 use Jifty::SubTest;
 use Jifty::Test tests => 9;
 use Jifty::Test::WWW::Mechanize;
@@ -16,13 +20,10 @@
 my $mech = Jifty::Test::WWW::Mechanize->new;
 
 $mech->get_ok($url . '/graphit', 'try getting /graphit');
-my $img_match = qr{<img src="(/chart/S\d+)" width="400" height="300"/>};
+my $img_match = qr{<img src="(/chart/\w+/S\d+)" width="400" height="300"/>};
 $mech->content_like($img_match, 'has an img tag');
 my ($chart_path) = $mech->content =~ $img_match;
 
-TODO: {
-local $TODO = "Always fail because eval 'use Chart::*' breaks file handles?";
-
 $mech->get_ok($url . $chart_path, 'try getting ' . $chart_path);
 
 my $response = $mech->response;
@@ -42,4 +43,3 @@
     is($info->{height}, 300, 'it is 300 pixels tall');
 };
 
-};


More information about the Jifty-commit mailing list