[Jifty-commit] r2007 - Jifty-DBI/trunk/lib/Jifty/DBI/Handle
jifty-commit at lists.jifty.org
jifty-commit at lists.jifty.org
Sun Oct 8 23:49:52 EDT 2006
Author: clkao
Date: Sun Oct 8 23:49:51 2006
New Revision: 2007
Modified:
Jifty-DBI/trunk/lib/Jifty/DBI/Handle/Pg.pm
Log:
Don't use main.*, ever.
Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Handle/Pg.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Handle/Pg.pm (original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Handle/Pg.pm Sun Oct 8 23:49:51 2006
@@ -216,10 +216,10 @@
my $group = $sb->_group_clause;
my $order = $sb->_order_clause;
$$statementref
- = "SELECT main.* FROM ( SELECT main.id FROM $$statementref $group $order ) distinctquery, $table main WHERE (main.id = distinctquery.id)";
+ = "SELECT ".$sb->_preload_columns." FROM ( SELECT main.id FROM $$statementref $group $order ) distinctquery, $table main WHERE (main.id = distinctquery.id)";
}
else {
- $$statementref = "SELECT DISTINCT main.* FROM $$statementref";
+ $$statementref = "SELECT DISTINCT ".$sb->_preload_columns." FROM $$statementref";
$$statementref .= $sb->_group_clause;
$$statementref .= $sb->_order_clause;
}
More information about the Jifty-commit
mailing list