[Jifty-commit] r2157 - in jifty/trunk: lib/Jifty/Web/Form
lib/Jifty/Web/Form/Field
jifty-commit at lists.jifty.org
jifty-commit at lists.jifty.org
Wed Nov 15 00:55:26 EST 2006
Author: jesse
Date: Wed Nov 15 00:55:25 2006
New Revision: 2157
Modified:
jifty/trunk/ (props changed)
jifty/trunk/lib/Jifty/Web/Form/Clickable.pm
jifty/trunk/lib/Jifty/Web/Form/Element.pm
jifty/trunk/lib/Jifty/Web/Form/Field/Button.pm
jifty/trunk/lib/Jifty/Web/Form/Field/Checkbox.pm
jifty/trunk/lib/Jifty/Web/Form/Field/Textarea.pm
jifty/trunk/lib/Jifty/Web/Form/Link.pm
Log:
r44856 at pinglin: jesse | 2006-11-15 00:47:45 -0500
* Finished backing out the "constant"ization of Jifty::Web::Form::*, which broke Hiveminder.
Modified: jifty/trunk/lib/Jifty/Web/Form/Clickable.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Clickable.pm (original)
+++ jifty/trunk/lib/Jifty/Web/Form/Clickable.pm Wed Nov 15 00:55:25 2006
@@ -23,15 +23,13 @@
=cut
-use constant ACCESSORS => qw(url escape_label tooltip continuation call
- returns submit target preserve_state
- render_as_button render_as_link);
sub accessors {
shift->SUPER::accessors,
- ACCESSORS
+ qw(url escape_label tooltip continuation call returns submit target preserve_state render_as_button render_as_link);
}
-__PACKAGE__->mk_accessors( ACCESSORS );
-
+__PACKAGE__->mk_accessors(
+ qw(url escape_label tooltip continuation call returns submit target preserve_state render_as_button render_as_link)
+);
=head2 new PARAMHASH
Modified: jifty/trunk/lib/Jifty/Web/Form/Element.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Element.pm (original)
+++ jifty/trunk/lib/Jifty/Web/Form/Element.pm Wed Nov 15 00:55:25 2006
@@ -134,7 +134,7 @@
=cut
-use constant handlers => qw(_onclick);
+sub handlers { qw(onclick); }
=head2 accessors
@@ -144,8 +144,8 @@
=cut
-use constant accessors => (__PACKAGE__->handlers, qw(class key_binding id label tooltip));
-__PACKAGE__->mk_accessors(__PACKAGE__->accessors);
+sub accessors { shift->handlers, qw(class key_binding id label tooltip) }
+__PACKAGE__->mk_accessors(qw(_onclick class key_binding id label tooltip));
=head2 new PARAMHASH OVERRIDE
Modified: jifty/trunk/lib/Jifty/Web/Form/Field/Button.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Field/Button.pm (original)
+++ jifty/trunk/lib/Jifty/Web/Form/Field/Button.pm Wed Nov 15 00:55:25 2006
@@ -4,6 +4,7 @@
package Jifty::Web::Form::Field::Button;
use base qw/Jifty::Web::Form::Field/;
+__PACKAGE__->mk_accessors(qw/button_as_link/);
=head2 accessors
@@ -13,9 +14,7 @@
=cut
-use constant ACCESSORS => qw(button_as_link);
-sub accessors { shift->SUPER::accessors(), ACCESSORS }
-__PACKAGE__->mk_accessors(ACCESSORS);
+sub accessors { shift->SUPER::accessors(), 'button_as_link' }
=head2 render_widget
Modified: jifty/trunk/lib/Jifty/Web/Form/Field/Checkbox.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Field/Checkbox.pm (original)
+++ jifty/trunk/lib/Jifty/Web/Form/Field/Checkbox.pm Wed Nov 15 00:55:25 2006
@@ -4,6 +4,7 @@
package Jifty::Web::Form::Field::Checkbox;
use base qw/Jifty::Web::Form::Field/;
+__PACKAGE__->mk_accessors(qw/checked value/);
=head2 accessors
@@ -13,9 +14,7 @@
=cut
-use constant ACCESSORS => qw(checked value);
-sub accessors { shift->SUPER::accessors(), ACCESSORS }
-__PACKAGE__->mk_accessors(ACCESSORS);
+sub accessors { shift->SUPER::accessors(), 'checked' , 'value' }
=head2 render_widget
Modified: jifty/trunk/lib/Jifty/Web/Form/Field/Textarea.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Field/Textarea.pm (original)
+++ jifty/trunk/lib/Jifty/Web/Form/Field/Textarea.pm Wed Nov 15 00:55:25 2006
@@ -5,6 +5,7 @@
use base qw/Jifty::Web::Form::Field/;
+__PACKAGE__->mk_accessors(qw(rows cols));
=head2 accessors
@@ -13,9 +14,7 @@
=cut
-use constant ACCESSORS => qw(rows cols);
-sub accessors { shift->SUPER::accessors(), ACCESSORS }
-__PACKAGE__->mk_accessors(ACCESSORS);
+sub accessors { shift->SUPER::accessors(), 'rows', 'cols' }
=head2 render_widget
Modified: jifty/trunk/lib/Jifty/Web/Form/Link.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Link.pm (original)
+++ jifty/trunk/lib/Jifty/Web/Form/Link.pm Wed Nov 15 00:55:25 2006
@@ -31,9 +31,8 @@
=cut
-use constant ACCESSORS => qw(url escape_label tooltip target);
-sub accessors { shift->SUPER::accessors(), ACCESSORS }
-__PACKAGE__->mk_accessors(ACCESSORS);
+sub accessors { shift->SUPER::accessors(), qw(url escape_label tooltip target); }
+__PACKAGE__->mk_accessors(qw(url escape_label tooltip target));
=head2 new PARAMHASH
More information about the Jifty-commit
mailing list