[Jifty-commit] r1005 - in Jifty-DBI/trunk: lib/Jifty/DBI

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Fri May 5 16:11:02 EDT 2006


Author: ewilhelm
Date: Fri May  5 16:10:49 2006
New Revision: 1005

Modified:
   Jifty-DBI/trunk/   (props changed)
   Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm

Log:
 r845 at mjolnir:  ewilhelm | 2006-04-23 22:38:45 -0700
 lib/Jifty/DBI/Record.pm - do not try to set_<foo>() a collection
 t/11schema_records.t - added tests for trying to set a collection


Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	(original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm	Fri May  5 16:10:49 2006
@@ -305,15 +305,9 @@
     elsif (
         UNIVERSAL::isa( $column->refers_to, "Jifty::DBI::Collection" ) )
     { # XXX elw: collections land here, now what?
-      my $ret = Class::ReturnValue->new();
-      my $message = "Collection column '$column_name' not writable";
-      $ret->as_array( 0, $message );
-      $ret->as_error(
-          errno        => 3,
-          do_backtrace => 0,
-          message      => $message
-      );
-      $subref = sub { return ( $ret->return_value ); };
+      $subref = sub {
+          return (0, "Collection column '$column_name' not writable")
+      };
     }
     else {
       $subref = sub {


More information about the Jifty-commit mailing list