[Jifty-commit] r696 - in jifty/trunk: lib/Jifty
jifty-commit at lists.jifty.org
jifty-commit at lists.jifty.org
Thu Mar 16 18:06:39 EST 2006
Author: alexmv
Date: Thu Mar 16 18:06:38 2006
New Revision: 696
Modified:
jifty/trunk/ (props changed)
jifty/trunk/lib/Jifty/Action.pm
Log:
r8595 at zoq-fot-pik: chmrr | 2006-03-16 18:01:59 -0500
* Make canonicalize look more like validate
Modified: jifty/trunk/lib/Jifty/Action.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Action.pm (original)
+++ jifty/trunk/lib/Jifty/Action.pm Thu Mar 16 18:06:38 2006
@@ -535,11 +535,9 @@
# better solution.
sub _canonicalize_arguments {
my $self = shift;
- my @fields = $self->argument_names;
- foreach my $field (@fields) {
- $self->_canonicalize_argument($field) if exists $self->argument_values->{$field};
- }
+ $self->_canonicalize_argument($_)
+ for $self->argument_names;
}
@@ -565,13 +563,13 @@
my $value = $self->argument_value($field);
my $default_method = 'canonicalize_' . $field;
+ return unless defined $value;
+
if ( $field_info->{canonicalizer}
and defined &{ $field_info->{canonicalizer} } )
{
$value = $field_info->{canonicalizer}->( $self, $value );
- }
-
- elsif ( $self->can($default_method) ) {
+ } elsif ( $self->can($default_method) ) {
$value = $self->$default_method( $value );
}
More information about the Jifty-commit
mailing list