[Jifty-commit] r1530 - in jifty: .

[jifty-commit at lists.jifty.org]

Author: nelhage
Date: Tue Jul 11 15:13:21 2006
New Revision: 1530

Modified:
   jifty/   (props changed)
   jifty/trunk/lib/Jifty/Web/Form/Clickable.pm

Log:
 r14125 at phanatique:  nelhage | 2006-07-11 14:44:05 -0400
 Note about a small bug we have to work around in BTDT


Modified: jifty/trunk/lib/Jifty/Web/Form/Clickable.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Web/Form/Clickable.pm	(original)
+++ jifty/trunk/lib/Jifty/Web/Form/Clickable.pm	Tue Jul 11 15:13:21 2006
@@ -494,9 +494,12 @@
 
 =cut
 
+## XXX TODO: This code somewhat duplicates hook-handling logic in
+## Element.pm, in terms of handling shortcuts like
+## 'refresh_self'. Some of the logic should probably be unified.
+
 sub generate {
     my $self = shift;
-
     for my $trigger ( $self->handlers ) {
         my $value = $self->$trigger;
         next unless $value;
@@ -516,6 +519,7 @@
                 } 
                 # Toggle region if the toggle flag is set, and clicking wouldn't change path
                 if ($hook->{toggle} and $hook->{replace_with} eq $currently_shown) {
+                    warn "Toggling region @{[$hook->{region}]} to empty";
                     $self->region_fragment( $hook->{region}, "/__jifty/empty" );
 #                    Jifty->web->request->remove_state_variable('region-'.$region->qualified_name);
                 } else {