[Jifty-commit] r1520 - jifty/trunk/lib/Jifty

jifty-commit at lists.jifty.org jifty-commit at lists.jifty.org
Mon Jul 10 12:44:00 EDT 2006


Author: clkao
Date: Mon Jul 10 12:43:53 2006
New Revision: 1520

Modified:
   jifty/trunk/lib/Jifty/Action.pm

Log:
Less calls to ->arguments, though they might be cached already.


Modified: jifty/trunk/lib/Jifty/Action.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Action.pm	(original)
+++ jifty/trunk/lib/Jifty/Action.pm	Mon Jul 10 12:43:53 2006
@@ -500,10 +500,11 @@
         Jifty->web->form->print_action_registration($self->moniker);
     } elsif ( not Jifty->web->form->printed_actions->{ $self->moniker } ) {
         # Otherwise, if we're not registered yet, do it in the button
+        my $arguments = $self->arguments;
         $args{parameters}{ $self->register_name } = ref $self;
         $args{parameters}{ $self->double_fallback_form_field_name($_) }
-            = $self->argument_value($_) || $self->arguments->{$_}->{'default_value'}
-            for grep { $self->arguments->{$_}{constructor} } keys %{ $self->arguments };
+            = $self->argument_value($_) || $arguments->{$_}->{'default_value'}
+            for grep { $arguments->{$_}{constructor} } keys %{ $arguments };
     }
     $args{parameters}{$self->form_field_name($_)} = $args{arguments}{$_}
       for keys %{$args{arguments}};


More information about the Jifty-commit mailing list