[Jifty-commit] r1509 - in Jifty-DBI/trunk: lib/Jifty/DBI
jifty-commit at lists.jifty.org
jifty-commit at lists.jifty.org
Fri Jul 7 15:08:09 EDT 2006
Author: zev
Date: Fri Jul 7 15:08:08 2006
New Revision: 1509
Modified:
Jifty-DBI/trunk/ (props changed)
Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
Jifty-DBI/trunk/lib/Jifty/DBI/Handle.pm
Log:
r11398 at galvatron: zev | 2006-07-07 15:07:59 -0400
* fixed handling of case sensitivity and numeric columns so opertions
like '>' do numeric instead of lexical comparisons
Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm (original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm Fri Jul 7 15:08:08 2006
@@ -698,7 +698,8 @@
=item case_sensitive
on some databases, such as postgres, setting case_sensitive to 1 will make
-this search case sensitive
+this search case sensitive. Note that this flag is ignored if the column
+is numeric.
=back
@@ -828,6 +829,8 @@
# If it's a new value or we're overwriting this sort of restriction,
if ( $self->_handle->case_sensitive
+ # don't worry about case for numeric columns
+ && ! $self->new_item()->column($args{column})->is_numeric
&& defined $args{'value'}
&& $args{'value'} ne ''
&& $args{'value'} ne "''"
Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Handle.pm
==============================================================================
--- Jifty-DBI/trunk/lib/Jifty/DBI/Handle.pm (original)
+++ Jifty-DBI/trunk/lib/Jifty/DBI/Handle.pm Fri Jul 7 15:08:08 2006
@@ -603,7 +603,7 @@
my $operator = shift;
my $value = shift;
- if ( $value !~ /^\d+$/ ) { # don't downcase integer values
+ if ( $value !~ /^['"]?\d+['"]?$/ ) { # don't downcase integer values
$column = "lower($column)";
$value = "lower($value)";
}
More information about the Jifty-commit
mailing list