[jifty-devel] [bug] Jifty's I18N support

[Jesse Vincent]

Agent,

I'm seeing a whole bunch of new test failures in the REST tests in the
jifty core after your latest tests (Also, a 15% performance penalty) Are
you seeing the same?


On Wed, Jan 24, 2007 at 03:56:46PM +0800, Agent Zhang wrote:
> On 1/24/07, Jesse Vincent <jesse at bestpractical.com> wrote:
> >
> >On Wed, Jan 24, 2007 at 11:45:58AM +0800, Agent Zhang wrote:
> >>
> >> Jifty's I18N support has stopped to work for me. I think it *used* to 
> >work.
> >> :(
> 
> With my patch in r2545, Jifty's I18N should work for (at least)
> standalone servers:
> 
>    http://svn.jifty.org/index.cgi/jifty/revision?rev=2545
> 
> To summarize, Jifty now calls Jifty::I18N->get_handle() to update the
> locale handle per HTTP request instead of per application instance. I
> think this is the correct behavior. :)
> 
> >>
> >> Experiments have shown that Jifty::I18N->new has to be called per
> >> request in order to make internationalization take effect. Simply
> >> calling Jifty::I18N->refresh per request (just as in the Devel mode)
> >> has no effect either.
> 
> The reason that calling Jifty::I18N->new per request worked for me was
> that C<new()> called C<get_handle()> (that has been mentioned above).
> 
> >>  Of cause, forcing Jifty::Handle to reconstruct
> >> Jifty::I18N every time a user request comes is certainly suboptimal,
> 
> The current approach I'm taking has some expense too, but it's quite
> small especially when the Devel mode is off. :)
> 
> >Audrey had a commit that touched this stuff a month or two back.  Try
> >seeing what would happen if you refer r2165?
> >
> 
> I think this bug has nothing to do with Audrey's previous patches.
> I've scanned through her commits and some others'. :)
> 
> >
> >>
> >> FYI, I'm developing a patient management system in Jifty for a Chinese
> >> hospital and I really need I18N in this project...
> >
> >That's very cool. Any chance it will be opensource?
> >
> 
> I think it will be opensource. I'll talk to my $customer later. I'll
> let you know. :)
> 
> Cheers,
> Agent
> _______________________________________________
> jifty-devel mailing list
> jifty-devel at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel
> 

--