[jifty-devel] Proposed change to SchemaGenerator

[Jesse Vincent]

On Thu, Feb 22, 2007 at 10:18:43AM -0600, Andrew Sterling Hanenkamp wrote:
> Before I push this back into Subversion, I want to make sure it's an
> okay idea. The patch makes some changes to the behavior of
> SchemaGenerator, which is fundamental and I want to clear it first.
>  
> I propose to add a new accessor to Jifty::DBI::SchemaGenerator named
> "app_version" and a constructor argument to set the app_version. The
> app_version to the constructor is optional. 
> 
> If app_version is not given, then it assumes the latest application
> version, which means that any column with "till" specified in the schema
> will not be created, but all others will be. 

Would it make sense to call it schema_version instead of app_version?

It seems like a reasonable idea. (I was initially quite hesitant about
putting this logic that far down the stack. Traditionally JDBI didn't
understand DB versioning. But on reflection, it seems a good idea.)

-jesse