[jifty-devel] Re: [Jifty-commit] r3908 - in Jifty-DBI/trunk: . lib/Jifty/DBI

Thomas Sibley trs at bestpractical.com
Thu Aug 16 15:30:16 EDT 2007


jifty-commit at lists.jifty.org wrote:
> Author: sterling
> Date: Thu Aug 16 10:02:48 2007
> New Revision: 3908
> 
> Modified: Jifty-DBI/trunk/lib/Jifty/DBI/Schema.pm
> ==============================================================================
> --- Jifty-DBI/trunk/lib/Jifty/DBI/Schema.pm	(original)
> +++ Jifty-DBI/trunk/lib/Jifty/DBI/Schema.pm	Thu Aug 16 10:02:48 2007
> @@ -346,6 +346,9 @@
>          # A one-to-one or one-to-many relationship is requested
>          if ( UNIVERSAL::isa( $refclass, 'Jifty::DBI::Record' ) ) {
>  
> +            # Make this a virtual record reference if they set by
> +            $column->virtual(1) if defined $column->by and $column->by ne 'id';
> +

The addition of the above line means that a column can't reference a 
record by anything other than the id column, which is wrong and breaks 
existing code.  Can you back it out (or fix it to be right)?

Tom


More information about the jifty-devel mailing list