[jifty-devel] Jifty::DBI quoting bug with PostgreSQL bool fields

[Sean E. Millichamp]

On Wed, 2006-09-06 at 00:21 -0400, Jesse Vincent wrote:

> On Tue, Sep 05, 2006 at 07:55:00AM -0400, Sean E. Millichamp wrote:
> > I have not (and probably will not for a while) had the time to actually
> > find what is needed to fix this, but I thought I'd mention it if someone
> > else wants to look into it.  I should further state that I haven't even
> > confirmed if it is a Jifty bug or a Jifty::DBI bug.
> 
> I think this is a case of "Different databases define boolean operators
> differently"  Will everything always take unquoted true and false?  I
> think jifty::dbi may just need to be smarter about bool types, but I'd
> be happiest if we can find a [database] platform-independent way to do it.

Well, SQLite will not take true and false unquoted, and but even if you
do pass them quoted (Postgres will take true and false both quoted and
unquoted) they seem to end up being evaluated and fetched as strings
later, not as true/false 0/1 boolean values.  

For Postgres and SQLite a solution would be to make sure that all
numerical default values are always quoted when the CREATE TABLE is
issued (at least for bool columns) and then pass 0/1 as the value in the
column definition.  That seems to satisfy both.  I have no idea about
MySQL or others, but I would like to think a quoted 0/1 would always be
acceptable for a bool.

Sean

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : http://lists.bestpractical.com/pipermail/jifty-devel/attachments/20060906/9c703779/attachment-0001.pgp