[jifty-devel] [fwd] Jifty::JSON has misleading VERSION codes (from: merlyn@stonehenge.com)

[jesse]

Thoughts? Opinions?
----- Forwarded message from "Randal L. Schwartz" <merlyn at stonehenge.com> -----

X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on 
	diesel.bestpractical.com
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=7.0 tests=AWL,BAYES_00,
	DNS_FROM_RFC_ABUSE autolearn=no version=3.1.1
To: jesse+cpan at fsck.com
Subject: Jifty::JSON has misleading VERSION codes
From: "Randal L. Schwartz" <merlyn at stonehenge.com>
Date: 03 May 2006 17:06:19 -0700


This is a *bad* line to have in Jifty/JSON.pm:

 if (eval { require JSON::Syck; $JSON::Syck::VERSION >= 0.05 }) {

because it makes CPAN.pm blow up like:

Could not eval '
            package ExtUtils::MakeMaker::_version;
            no strict;

            local $JSON::Syck::VERSION;
            $JSON::Syck::VERSION=undef; do {
                    if (eval { require JSON::Syck; $JSON::Syck::VERSION >= 0.05 }) {
            }; $JSON::Syck::VERSION
        ' in /opt/perl/snap/lib/site_perl/5.8.8/Jifty/JSON.pm: Missing right curly or square bracket at (eval 6064) line 10, at end of line
syntax error at (eval 6064) line 10, at EOF
Jifty::JSON                   undef      1.02  JESSE/Jifty-0.51228.tar.gz


-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn at stonehenge.com> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!


----- End forwarded message -----

--