[jifty-devel] Re: [Jifty-commit] r1350 - in jifty/trunk: . lib/Jifty lib/Jifty/Web lib/Jifty/Web/Form/Field share/web/static/css share/web/templates/_elements

Jesse Vincent jesse at bestpractical.com
Thu Jun 22 18:34:29 EDT 2006




On Thu, Jun 22, 2006 at 04:51:04PM -0400, Sean E. Millichamp wrote:
> > 
> > This hunk breaks screen-readers and the like, which, for proper HTML
> > accessibility, need a <label> element.  What's the error that this was
> > trying to fix?
> 
> I actually figured that this would be a fairly unobtrusive change, but I
> hadn't considered screen readers.
> 
> Mostly as an academic exercise, I was trying to see if I could get Jifty
> closer to XHTML 1.0 Strict validation without visibly changing the pages
> I was testing with.
> 
> The <label> elements were causing errors since most of the form field
> values were rendering as <span> elements when render_mode was 'read' and
> the <label> elements were invalid without <input> elements, and they
> referenced element id's that didn't exist.  Not considering screen
> readers and the like, switching them from <label> to <span> seemed to
> give the same behavior and rendering, and eliminated the errors.
> 
> Should I back the change out?

I expect that bart would be the right person to ask. (bartb is our
resident screenreader user and accessibility goto guy ;)

Bart, 

whatcha think?

Jesse

> Sean
> 
> -- 
>  Sean E. Millichamp, Enertron LLC, 586-757-1200 x102
> 



> _______________________________________________
> jifty-devel mailing list
> jifty-devel at lists.jifty.org
> http://lists.jifty.org/cgi-bin/mailman/listinfo/jifty-devel


-- 


More information about the jifty-devel mailing list