[jifty-devel] Re: [Jifty-commit] r1237 - in Jifty-DBI/trunk: . lib/Jifty lib/Jifty/DBI

[Jesse Vincent]

On Fri, Jun 09, 2006 at 06:29:00PM -0400, jifty-commit at lists.jifty.org wrote:
> Author: seanmil
> Date: Fri Jun  9 18:28:55 2006
> New Revision: 1237
> 
> Modified:
>    Jifty-DBI/trunk/   (props changed)
>    Jifty-DBI/trunk/lib/Jifty/DBI.pm
>    Jifty-DBI/trunk/lib/Jifty/DBI/Collection.pm
>    Jifty-DBI/trunk/lib/Jifty/DBI/Record.pm
>    Jifty-DBI/trunk/t/01records.t
>    Jifty-DBI/trunk/t/01searches.t
>    Jifty-DBI/trunk/t/02-column_constraints.t
>    Jifty-DBI/trunk/t/02records_object.t
>    Jifty-DBI/trunk/t/06filter_datetime.t
>    Jifty-DBI/trunk/t/06filter_truncate.t
>    Jifty-DBI/trunk/t/06filter_utf8.t
>    Jifty-DBI/trunk/t/11schema_records.t
>    Jifty-DBI/trunk/t/utils.pl
> 
> Log:
>  r439 at pc102:  sean | 2006-06-09 18:28:49 -0400
>  * Make Jifty::DBI::Record::_init() expect a hash like Jifty::Record does
>  * Fixes 'is_distinct' failure when used in Jifty
>  
> 

It looks like this is a bit of a backwards incompatible change, but that
it would be pretty easy to fix. Breaking APIs is ungood, especially when
there's code out there that depends on the old API.  If there _is_ a
reason to break the API, it should get flagged good and loud.

-jesse