[jifty-devel] Re: [Jifty-commit] r871 - in jifty/trunk: lib/Jifty lib/Jifty/Test/WWW

[Jesse Vincent]

>   * Note that skipping undef values for canonicalization is a bit odd

I have a recollection that we were running into trouble with Jifty
canonicalizing non-submitted values, which was definitely wrong in the
context.


> 
> Modified: jifty/trunk/lib/Jifty/Action.pm
> ==============================================================================
> --- jifty/trunk/lib/Jifty/Action.pm	(original)
> +++ jifty/trunk/lib/Jifty/Action.pm	Wed Apr 19 01:48:10 2006
> @@ -573,6 +573,7 @@
>      my $value = $self->argument_value($field);
>      my $default_method = 'canonicalize_' . $field;
>  
> +    # XXX TODO: Do we really want to skip undef values?
>      return unless defined $value;
>  
>      if ( $field_info->{canonicalizer}