[Jifty-commit] jifty branch, autocomplete-refactor, updated. d586782303235a95b0b0f7a90431957d84611c3c

Jifty commits jifty-commit at lists.jifty.org
Mon Mar 22 15:30:31 EDT 2010


The branch, autocomplete-refactor has been updated
       via  d586782303235a95b0b0f7a90431957d84611c3c (commit)
      from  0e5741cd38371a507279b13f8ad6f08dd2b5f1d9 (commit)

Summary of changes:
 lib/Jifty/Web/Form/Field.pm |   25 ++-----------------------
 1 files changed, 2 insertions(+), 23 deletions(-)

- Log -----------------------------------------------------------------
commit d586782303235a95b0b0f7a90431957d84611c3c
Author: Shawn M Moore <sartak at bestpractical.com>
Date:   Mon Mar 22 15:30:25 2010 -0400

    Don't render autocomplete_divs, our new autocomplete plugin does it

diff --git a/lib/Jifty/Web/Form/Field.pm b/lib/Jifty/Web/Form/Field.pm
index 5d6db4d..ac4c4a9 100644
--- a/lib/Jifty/Web/Form/Field.pm
+++ b/lib/Jifty/Web/Form/Field.pm
@@ -393,7 +393,6 @@ sub render {
     $self->render_label();
     if ($self->render_mode eq 'update') { 
         $self->render_widget();
-        $self->render_autocomplete_div();
         $self->render_inline_javascript();
         $self->render_hints();
         $self->render_errors();
@@ -643,28 +642,11 @@ sub render_value {
 
 
 
-=head2 render_autocomplete_div
-
-Renders an empty div that /__jifty/autocomplete.xml can fill
-in. Returns an empty string.
-
-=cut
-
-sub render_autocomplete_div { 
-    my $self = shift;
-    return unless($self->autocompleter);
-    Jifty->web->out(
-qq!<div class="autocomplete" id="@{[$self->element_id]}-autocomplete" style="display: none;"></div>!);
-
-    return '';
-}
-
 =head2 render_autocomplete
 
 Renders the div tag and javascript necessary to do autocompletion for
-this form field. Deprecated internally in favor of
-L</render_autocomplete_div> and L</autocomplete_javascript>, but kept
-for backwards compatability since there exists external code that uses
+this form field. Deprecated internally in favor of L</autocomplete_javascript>,
+but kept for backwards compatability since there exists external code that uses
 it.
 
 =cut
@@ -672,13 +654,10 @@ it.
 sub render_autocomplete {
     my $self = shift;
     return unless $self->autocompleter;
-    $self->render_autocomplete_div;
     Jifty->web->out(qq!<script type="text/javascript">@{[$self->autocomplete_javascript]}</script>!);
     return '';
 }
 
-
-
 =head2 autocomplete_javascript
 
 Returns renders the tiny snippet of javascript to make an autocomplete

-----------------------------------------------------------------------


More information about the Jifty-commit mailing list