[Jifty-commit] jifty branch, master, updated. 4a3cce8dc2e7bc621fbd338bdea0a32818174380
Jifty commits
jifty-commit at lists.jifty.org
Wed Dec 8 16:08:04 EST 2010
The branch, master has been updated
via 4a3cce8dc2e7bc621fbd338bdea0a32818174380 (commit)
via 03cfe408281d46c9181e78c1329b78004e64ef30 (commit)
via 812fd42ca337618813a29922200a971957790028 (commit)
from 4a5d376d6efffbea5383581eee8edea51d1784b6 (commit)
Summary of changes:
lib/Jifty/Plugin/REST/Dispatcher.pm | 2 +-
lib/Jifty/Test.pm | 6 +++---
t/TestApp-Plugin-PasswordAuth/t/00-model-User.t | 10 +++++-----
3 files changed, 9 insertions(+), 9 deletions(-)
- Log -----------------------------------------------------------------
commit 812fd42ca337618813a29922200a971957790028
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Dec 8 14:35:52 2010 -0500
Minor doc fix ups
diff --git a/lib/Jifty/Test.pm b/lib/Jifty/Test.pm
index d85cc36..0b94389 100644
--- a/lib/Jifty/Test.pm
+++ b/lib/Jifty/Test.pm
@@ -473,9 +473,9 @@ sub _testfile_to_dbname {
=head2 make_server
Creates a new L<Jifty::TestServer> depending on the value of
-$ENV{JIFTY_TEST_SERVER}. If the environment variable is unset or
-C<Inline>, we run tests using PSGI inline wihtout spawning an actual
-server. Otherwise, we fork off a Plack::Server to run tests against.
+C<$ENV{JIFTY_TEST_SERVER}>. If the environment variable is C<Inline>,
+we run tests using PSGI inline without spawning an actual server.
+Otherwise, we fork off a L<Plack::Server> to run tests against.
=cut
commit 03cfe408281d46c9181e78c1329b78004e64ef30
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Dec 8 16:06:33 2010 -0500
Avoid XML::Simple warning on undef values by setting SuppressEmpty to undef
diff --git a/lib/Jifty/Plugin/REST/Dispatcher.pm b/lib/Jifty/Plugin/REST/Dispatcher.pm
index e7c9f5e..9cea1cc 100644
--- a/lib/Jifty/Plugin/REST/Dispatcher.pm
+++ b/lib/Jifty/Plugin/REST/Dispatcher.pm
@@ -297,7 +297,7 @@ sub outs {
last_rule;
}
-our $xml_config = { SuppressEmpty => '',
+our $xml_config = { SuppressEmpty => undef,
NoAttr => 1,
RootName => 'data' };
commit 4a3cce8dc2e7bc621fbd338bdea0a32818174380
Author: Thomas Sibley <trs at bestpractical.com>
Date: Wed Dec 8 16:07:22 2010 -0500
Update tests with an explanation, warning avoidance, and a short pass test
diff --git a/t/TestApp-Plugin-PasswordAuth/t/00-model-User.t b/t/TestApp-Plugin-PasswordAuth/t/00-model-User.t
index 6669431..11fae0d 100644
--- a/t/TestApp-Plugin-PasswordAuth/t/00-model-User.t
+++ b/t/TestApp-Plugin-PasswordAuth/t/00-model-User.t
@@ -70,9 +70,9 @@ ok($id, "Created with grey");
my ($res, $msg) = $r->set_password('foo');
TODO: {
-local $TODO = 'huh?';
+local $TODO = 'Validators are applied too late - [rt.cpan.org #63750]';
ok(!$res, 'unable to set password shorter than 6');
-like($msg, qr/at least six/);
+like($msg||'', qr/at least six/);
ok($r->password_is('secret'), 'password not changed');
};
@@ -82,15 +82,15 @@ ok($r->password_is('secret'), 'password not changed');
password => '',
swallow_type => 'african' );
-ok(!$id, "Can't creaet without password");
+ok(!$id, "Can't create without password");
like($msg, qr/at least six/);
($id, $msg) = $r->create( name => 'jesse3',
email => 'jrv2 at orz',
color => 'gray',
- password => '',
+ password => 'short',
swallow_type => 'african' );
-ok(!$id, "Can't create without password");
+ok(!$id, "Can't create with a short password");
like($msg, qr/at least six/);
-----------------------------------------------------------------------
More information about the Jifty-commit
mailing list