[Jifty-commit] r7500 - jifty/trunk/lib/Jifty

[Jifty commits]

Author: sartak
Date: Tue Sep 29 16:06:01 2009
New Revision: 7500

Modified:
   jifty/trunk/lib/Jifty/Action.pm

Log:
Improve clarity of _values_for_field

Modified: jifty/trunk/lib/Jifty/Action.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Action.pm	(original)
+++ jifty/trunk/lib/Jifty/Action.pm	Tue Sep 29 16:06:01 2009
@@ -1094,7 +1094,7 @@
     my @values = eval { @$vv_orig } or return $vv_orig;
 
     # This is a final return list
-    my $vv = [];
+    my @vv;
 
     # For each value in the *_values list
     for my $v (@values) {
@@ -1121,7 +1121,7 @@
                 # XXX TODO: wrap this in an eval?
 
                 # Fetch all the record from the given collection and keep'em
-                push @$vv, map {
+                push @vv, map {
                     {
                         display => ( $_->$disp() || '' ),
                         value   => ( $_->$val()  || '' )
@@ -1134,7 +1134,7 @@
             else {
 
                 # assume it's already display/value
-                push @$vv, $v;
+                push @vv, $v;
             }
         }
 
@@ -1142,11 +1142,11 @@
         else {
 
             # just a string
-            push @$vv, { display => $v, value => $v };
+            push @vv, { display => $v, value => $v };
         }
     }
 
-    return $vv;
+    return \@vv;
 }
 
 =head2 validation_error ARGUMENT => ERROR TEXT, [OPTIONS]