[Jifty-commit] r7116 - in jifty/trunk: lib/Jifty

[Jifty commits]

Author: jesse
Date: Wed May 27 17:17:11 2009
New Revision: 7116

Modified:
   jifty/trunk/   (props changed)
   jifty/trunk/lib/Jifty/Test.pm

Log:
 r63690 at 17h:  jesse | 2009-05-27 17:17:04 -0400
 Add a warning and an admonishment


Modified: jifty/trunk/lib/Jifty/Test.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Test.pm	(original)
+++ jifty/trunk/lib/Jifty/Test.pm	Wed May 27 17:17:11 2009
@@ -623,8 +623,12 @@
         warn "Uncaught warning: $_" for $plugin->stashed_warnings;
     }
 
-    # Such a hack -- try to detect if this is a forked copy and don't
+    # Such a hack -- try to detect if this is a forked child process and don't
     # do cleanup in that case.
+    # TODO: note that this check fails if you're forking off multiple
+    # children that all do similar things, say running RT and Jifty tests
+    # in the same process
+    # XXX TODO - This makes assumptions about Test::Builder internals
     return if $Test->{Original_Pid} != $$;
 
     # If all tests passed..
@@ -649,6 +653,9 @@
             # this shouldn't kill tests
             local $@; 
             eval { $schema->run };
+            if (my $err = $@) { 
+                warn $err;
+            }
         }
 
         # Unlink test files