[Jifty-commit] r7087 - in plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin: SiteNews/Mixin/Model SiteNews/View

[Jifty commits]

Author: alexmv
Date: Wed May 20 16:40:37 2009
New Revision: 7087

Modified:
   plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews.pm
   plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/Mixin/Model/News.pm
   plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/View/News.pm

Log:
Remove vestigal author, add documentation, hide sort header

Modified: plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews.pm
==============================================================================
--- plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews.pm	(original)
+++ plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews.pm	Wed May 20 16:40:37 2009
@@ -11,7 +11,20 @@
 
 =head1 DESCRIPTION
 
-Provides a way to include site news in your Jifty app
+Provides a way to include site news in your Jifty app.  To use it, you
+will need to add a news model:
+
+  package YourApp::Model::News;
+  use Jifty::DBI::Schema;
+  use YourApp::Record schema {
+    # ..additional properties go here, like 'author'
+  };
+  use Jifty::Plugin::SiteNews::Mixin::Model::News;
+
+You will also need to alias the view somewhere; from YourApp::View:
+
+  require Jifty::Plugin::SiteNews::View::News;
+  alias Jifty::Plugin::SiteNews::View::News under '/news';
 
 =cut
 

Modified: plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/Mixin/Model/News.pm
==============================================================================
--- plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/Mixin/Model/News.pm	(original)
+++ plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/Mixin/Model/News.pm	Wed May 20 16:40:37 2009
@@ -15,13 +15,11 @@
 
 use Jifty::Record schema {
 
-    my $user_class = Jifty->app_class('Model', 'News');
-
-#column author_id => refers_to $user_class; label is 'Author';
 column created   =>
   type is 'timestamp',
   filters are qw( Jifty::Filter::DateTime Jifty::DBI::Filter::DateTime),
-  label is 'Created on';
+  label is 'Created on',
+  is protected;
 column title     =>
   type is 'text',
   label is 'Title';
@@ -40,35 +38,15 @@
 sub create {
     my $self = shift;
     my %args = (
-        author_id => $self->current_user->id,
-        created   => DateTime->now->iso8601,
         title     => undef,
         content   => undef,
-        @_
+        @_,
+        created   => DateTime->now->iso8601,
     );
 
     $self->SUPER::create(%args);
 }
 
-=head2 current_user_can
-
-Anyone can read news articles, only administrators can create, update,
-or delete them.
-
-=cut
-
-sub current_user_can {
-    my $self = shift;
-    my $right = shift;
-
-    return 1;
-    # Anyone can read
-    return 1 if ($right eq "read");
-    
-    # Only admins can do other things
-    return $self->current_user->user_object->access_level eq "staff";
-}
-
 =head2 as_atom_entry
 
 Returns the task as an L<XML::Atom::Entry> object.
@@ -78,11 +56,7 @@
 sub as_atom_entry {
     my $self = shift;
 
-    my $author = XML::Atom::Person->new;
-    $author->name($self->author->name);
-
     my $entry = XML::Atom::Entry->new;
-    $entry->author( $author );
     $entry->title( $self->title );
     $entry->content( $self->content);
     return $entry;

Modified: plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/View/News.pm
==============================================================================
--- plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/View/News.pm	(original)
+++ plugins/Jifty-Plugin-SiteNews/lib/Jifty/Plugin/SiteNews/View/News.pm	Wed May 20 16:40:37 2009
@@ -26,6 +26,8 @@
 
 template search_region => sub {''};
 
+template sort_header => sub {''};
+
 template 'index.html' => page {
     my $self = shift;
     title is  'Site news' ;
@@ -37,7 +39,6 @@
 
 };
 
-
 template 'view' => sub {
     my $self = shift;
     my ( $object_type, $id ) = ( $self->object_type, get('id') );