[Jifty-commit] r7013 - in plugins/Jifty-Plugin-OpenID: lib/Jifty/Plugin t/TestApp/lib/TestApp/Model t/TestApp/t

[Jifty commits]

Author: c9s
Date: Tue May 12 14:18:46 2009
New Revision: 7013

Modified:
   plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID.pm
   plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID/Action/CreateOpenIDUser.pm
   plugins/Jifty-Plugin-OpenID/t/TestApp/lib/TestApp/Model/User.pm
   plugins/Jifty-Plugin-OpenID/t/TestApp/t/00-openid-test.t

Log:
 fix OpenID documentation (brief_description part)


Modified: plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID.pm
==============================================================================
--- plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID.pm	(original)
+++ plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID.pm	Tue May 12 14:18:46 2009
@@ -37,17 +37,28 @@
 
 =head2 User Model
 
-create your User model , add a column named C<name> to the model.
-and let User model use L<Jifty::Plugin::OpenID::Mixin::Model::User>.
+OpenID plugin calls UserModel->brief_description to get a meaningful value of
+an unique id of an user record
+
+so create your user model , add a C<name> method named to return the readable
+user identity. and let User model use
+L<Jifty::Plugin::OpenID::Mixin::Model::User> to mixin "openid" column.
 
     use TestApp::Record schema {
 
-        column name =>
+        column email =>
             type is 'varchar';
 
     };
     use Jifty::Plugin::OpenID::Mixin::Model::User;
 
+    sub name {
+        my $self = shift;
+        return $self->email;
+    }
+
+See L<Jifty::Record> for C<brief_description> method.
+
 =head2 View
 
 OpenID plugin provides AuthenticateOpenID Action. so that you can render an

Modified: plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID/Action/CreateOpenIDUser.pm
==============================================================================
--- plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID/Action/CreateOpenIDUser.pm	(original)
+++ plugins/Jifty-Plugin-OpenID/lib/Jifty/Plugin/OpenID/Action/CreateOpenIDUser.pm	Tue May 12 14:18:46 2009
@@ -3,7 +3,7 @@
 
 =head1 NAME
 
-Jifty::Plugin::OpenID::Action::CreateOpenIDUser - create 0penId user
+Jifty::Plugin::OpenID::Action::CreateOpenIDUser - Create OpenID user
 
 =cut
 

Modified: plugins/Jifty-Plugin-OpenID/t/TestApp/lib/TestApp/Model/User.pm
==============================================================================
--- plugins/Jifty-Plugin-OpenID/t/TestApp/lib/TestApp/Model/User.pm	(original)
+++ plugins/Jifty-Plugin-OpenID/t/TestApp/lib/TestApp/Model/User.pm	Tue May 12 14:18:46 2009
@@ -6,9 +6,8 @@
 
 use TestApp::Record schema {
 
-
-column name =>
-    type is 'varchar';
+column email =>
+   type is 'varchar';
 
 };
 
@@ -16,5 +15,11 @@
 
 # Your model-specific methods go here.
 
+# Openid Plugin use brief_description to get an user identity.
+sub name {
+    my $self = shift;
+    $self->email;
+}
+
 1;
 

Modified: plugins/Jifty-Plugin-OpenID/t/TestApp/t/00-openid-test.t
==============================================================================
--- plugins/Jifty-Plugin-OpenID/t/TestApp/t/00-openid-test.t	(original)
+++ plugins/Jifty-Plugin-OpenID/t/TestApp/t/00-openid-test.t	Tue May 12 14:18:46 2009
@@ -37,14 +37,15 @@
 
 # match this name="J:A:F-name-auto-86d3fcd1a158d85fd2e6165fc00113c7-1"
 my $content = $mech->content();
-my ($field_name) = ($content =~ m[name="(J:A:F-name-auto-\w+-\d)"]gsm);
+my ($field_name) = ($content =~ m[name="(J:A:F-email-auto-\w+-\d)"]gsm);
 
 diag $field_name;
 
 $mech->submit_form(
     form_name => 'openid-user-create',
     fields    => { 
-        $field_name  => 'c9s'
+        # $field_name  => 'c9s'
+        $field_name  => 'c9s at c9s'
     },
     # button    => 'Continue'
 ); 
@@ -54,8 +55,8 @@
 
 
 my $u = TestApp::Model::User->new;
-$u->load_by_cols( name => 'c9s' );
+$u->load_by_cols( email => 'c9s at c9s' );
 
 ok( $u->id , 'found user' );
-is( $u->name , 'c9s' , 'found openid register user' );
+is( $u->email , 'c9s at c9s' , 'found openid register user' );
 is( $u->openid , $openid , 'match openid' );