[Jifty-commit] r6976 - jifty/trunk/lib/Jifty/Script

Jifty commits jifty-commit at lists.jifty.org
Mon May 11 14:55:05 EDT 2009


Author: alexmv
Date: Mon May 11 14:55:04 2009
New Revision: 6976

Modified:
   jifty/trunk/lib/Jifty/Script/Server.pm

Log:
Always specify _which_ file had errors opening when you die

Modified: jifty/trunk/lib/Jifty/Script/Server.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Script/Server.pm	(original)
+++ jifty/trunk/lib/Jifty/Script/Server.pm	Mon May 11 14:55:04 2009
@@ -146,7 +146,7 @@
 
     die 'fork failed' unless defined $pid;
     if ($pid) {
-        open my $fh, '>', PARENTPIDFILE or die $!;
+        open my $fh, '>', PARENTPIDFILE or die "Can't open @{[PARENTPIDFILE]} for writing: $!";
         print $fh $$;
         close $fh;
 
@@ -182,7 +182,7 @@
           and -d $data_dir;
 
     $SIG{TERM} = sub { exit };
-    open my $fh, '>', PIDFILE or die $!;
+    open my $fh, '>', PIDFILE or die "Can't open @{[PIDFILE]} for writing: $!";
     print $fh $$;
     close $fh;
 
@@ -202,7 +202,7 @@
 
 sub _stop {
     my $self = shift;
-    open my $fh, '<', PARENTPIDFILE or die $!;
+    open my $fh, '<', PARENTPIDFILE or die "Can't open @{[PARENTPIDFILE]} for reading: $!";
     my $pid = <$fh>;
     kill 'TERM' => $pid;
 
@@ -211,7 +211,7 @@
 }
 
 sub _stop_child {
-    open my $fh, '<', PIDFILE or die $!;
+    open my $fh, '<', PIDFILE or die "Can't open @{[PIDFILE]} for reading: $!";
     my $pid = <$fh>;
     kill 'TERM' => $pid;
 }


More information about the Jifty-commit mailing list