[Jifty-commit] r7237 - jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action

Jifty commits jifty-commit at lists.jifty.org
Thu Jun 11 15:34:49 EDT 2009


Author: sartak
Date: Thu Jun 11 15:34:49 2009
New Revision: 7237

Modified:
   jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm

Log:
Remove empty hash args for connect

Modified: jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/SetupWizard/Action/TestDatabaseConnectivity.pm	Thu Jun 11 15:34:49 2009
@@ -39,6 +39,13 @@
 sub take_action {
     my $self = shift;
 
+    # Remove empty arguments (empty port confuses DBI)
+    # Maybe should go in Jifty::DBI. it does handle undef..
+    my %args = %{ $self->argument_values };
+    for my $key (keys %args) {
+        delete $args{$key} if !defined($args{$key}) || !length($args{$key});
+    }
+
     my $handle = Jifty::DBI::Handle->new;
     my $ok = eval {
         local $SIG{__DIE__};


More information about the Jifty-commit mailing list