[Jifty-commit] r7433 - in jifty/trunk: lib/Jifty/View/Declare

Jifty commits jifty-commit at lists.jifty.org
Tue Aug 25 01:55:09 EDT 2009


Author: sartak
Date: Tue Aug 25 01:55:08 2009
New Revision: 7433

Modified:
   jifty/trunk/lib/Jifty/View/Declare/CRUD.pm
   jifty/trunk/share/web/static/css/crud.css

Log:
Remove some extraneous hierarchy as part of css-tabling CRUD

Modified: jifty/trunk/lib/Jifty/View/Declare/CRUD.pm
==============================================================================
--- jifty/trunk/lib/Jifty/View/Declare/CRUD.pm	(original)
+++ jifty/trunk/lib/Jifty/View/Declare/CRUD.pm	Tue Aug 25 01:55:08 2009
@@ -441,21 +441,18 @@
         moniker => "update-" . Jifty->web->serial,
     );
 
-    div {
-        { class is 'crud-item-view' };
-        my @fields = $self->display_columns;
-        for my $field (@fields) {
-            div { { class is 'crud-field view-argument-'.$field};
-                $self->render_field(
-                    mode   => 'view',
-                    action => $update,
-                    field  => $field,
-                    label  => '',
-                );
-            };
-        }
-        show ('./view_item_controls', $record, $update); 
-    };
+    my @fields = $self->display_columns;
+    for my $field (@fields) {
+        div { { class is 'crud-field view-argument-'.$field};
+            $self->render_field(
+                mode   => 'view',
+                action => $update,
+                field  => $field,
+                label  => '',
+            );
+        };
+    }
+    show ('./view_item_controls', $record, $update);
 };
 
 =head2 private template view_item_controls
@@ -670,7 +667,7 @@
                     outs $argument;
                 };
             }
-        };
+        }
     };
 };
 
@@ -819,25 +816,20 @@
         }
 
         my $i = 0;
-        div {
-            { class is 'list' };
-            while ( my $item = $collection->next ) {
-                div {
-                    class is ($i++ % 2 ? 'odd' : 'even');
-
-                    render_region(
-                        name     => 'item-' . $item->id,
-                        path     => $item_path,
-                        defaults => {
-                            id => $item->id,
-                            object_type => $object_type,
-                        }
-                    );
+        while ( my $item = $collection->next ) {
 
-                    $callback->($i) if $callback;
+            render_region(
+                name     => 'item-' . $item->id,
+                path     => $item_path,
+                class    => 'crud-item ' . ($i++ % 2 ? 'odd' : 'even'),
+                defaults => {
+                    id => $item->id,
+                    object_type => $object_type,
                 }
-            }
-        };
+            );
+
+            $callback->($i) if $callback;
+        }
     };
 };
 

Modified: jifty/trunk/share/web/static/css/crud.css
==============================================================================
--- jifty/trunk/share/web/static/css/crud.css	(original)
+++ jifty/trunk/share/web/static/css/crud.css	Tue Aug 25 01:55:08 2009
@@ -33,7 +33,7 @@
 .crud-create {
 }
 
-.crud-item-view {
+.crud-item {
     display: table-row;
 }
 


More information about the Jifty-commit mailing list