[Jifty-commit] r6888 - in jifty/trunk/lib/Jifty/Plugin: RequestInspector

[Jifty commits]

Author: sartak
Date: Fri Apr 24 00:12:28 2009
New Revision: 6888

Modified:
   jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm
   jifty/trunk/lib/Jifty/Plugin/SQLQueries/View.pm

Log:
Fix toggling of request inspector regions

Modified: jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/RequestInspector/View.pm	Fri Apr 24 00:12:28 2009
@@ -83,9 +83,6 @@
 
     dl {
         for my $plugin_name (sort keys %{ $request->{plugin_data} }) {
-            my $row_id = "request-$id-$plugin_name";
-            $row_id =~ s/::/-/g;
-
             my $plugin_data = $request->{plugin_data}{$plugin_name};
             my $plugin = Jifty->find_plugin($plugin_name);
 
@@ -95,7 +92,7 @@
                     hyperlink(
                         label => $short_name,
                         onclick => {
-                            element => "#$row_id",
+                            region => Jifty->web->qualified_region($plugin_name),
                             replace_with => '/__jifty/admin/requests/plugin',
                             toggle  => 1,
                             effect  => 'slideDown',
@@ -114,7 +111,7 @@
                 if ($plugin->can('inspect_render_summary')) {
                     outs $plugin->inspect_render_summary($plugin_data, $id);
                 }
-                div { attr { id is $row_id } };
+                render_region($plugin_name);
             };
         }
     };
@@ -142,7 +139,7 @@
         hyperlink(
             label => $request->{url},
             onclick => {
-                element   => "#request-$id",
+                region       => Jifty->web->qualified_region("request_$id"),
                 replace_with => '/__jifty/admin/requests/plugins',
                 toggle    => 1,
                 effect    => 'slideDown',
@@ -154,7 +151,7 @@
 
         outs sprintf ' (%.2gs)',  $request->{end} - $request->{start};
 
-        div { attr { id is "request-$id" } };
+        render_region("request_$id");
     };
 }
 

Modified: jifty/trunk/lib/Jifty/Plugin/SQLQueries/View.pm
==============================================================================
--- jifty/trunk/lib/Jifty/Plugin/SQLQueries/View.pm	(original)
+++ jifty/trunk/lib/Jifty/Plugin/SQLQueries/View.pm	Fri Apr 24 00:12:28 2009
@@ -15,7 +15,7 @@
                 hyperlink(
                     label => $query,
                     onclick => {
-                        element   => "#query-$id-$query_id",
+                        region    => Jifty->web->qualified_region("query_$query_id"),
                         replace_with => '/__jifty/admin/requests/query',
                         toggle    => 1,
                         effect    => 'slideDown',
@@ -26,7 +26,7 @@
                     },
                 );
 
-                div { attr { id is "query-$id-$query_id" } };
+                render_region("query_$query_id");
             };
         }
     }